Bug 168945 - Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
Summary: Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
: 168946 (view as bug list)
Depends on: 168939
Blocks: 171847
  Show dependency tree / graph
 
Reported: 2017-02-27 16:22 PST by Jonathan Bedard
Modified: 2017-05-08 22:11 PDT (History)
10 users (show)

See Also:

Attachments
Patch (34.13 KB, patch)
2017-05-04 14:22 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (32.69 KB, patch)
2017-05-05 08:22 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (32.68 KB, patch)
2017-05-05 15:06 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2017-02-27 16:22:57 PST 
Webkitpy should use the ImageDiff that is built by the host SDK rather than on built with the SDK being tested.
Comment 1 Radar WebKit Bug Importer 2017-02-27 16:23:59 PST 
<rdar://problem/30745695>
Comment 2 Jonathan Bedard 2017-05-04 13:45:16 PDT 
*** Bug 168946 has been marked as a duplicate of this bug. ***
Comment 3 Jonathan Bedard 2017-05-04 14:22:38 PDT 
Created attachment 309105 [details]
Patch
Comment 4 Jonathan Bedard 2017-05-04 14:25:28 PDT 
Comment on attachment 309105 [details]
Patch

CQ-ing since some archiving code needed to ensure this patch works internally has not yet been landed.
Comment 5 Jonathan Bedard 2017-05-05 08:22:22 PDT 
Created attachment 309169 [details]
Patch
Comment 6 Carlos Garcia Campos 2017-05-05 08:23:56 PDT 
Comment on attachment 309105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309105&action=review

> Tools/Scripts/build-webkit:307
> +if (!-e $command[0]) {
> +    die "build-imagediff script not found";
> +}

This should be done only for ports that use this script to build image diff.
Comment 7 Jonathan Bedard 2017-05-05 08:34:25 PDT 
Comment on attachment 309169 [details]
Patch

CQ-ing this again, see Comment 4.
Comment 8 Jonathan Bedard 2017-05-05 10:05:46 PDT 
Comment on attachment 309169 [details]
Patch

Internal infrastructure has been updated.  This patch should be ready to go.
Comment 9 David Kilzer (:ddkilzer) 2017-05-05 12:15:40 PDT 
Comment on attachment 309169 [details]
Patch

r=me
Comment 10 WebKit Commit Bot 2017-05-05 12:26:40 PDT 
Comment on attachment 309169 [details]
Patch

Clearing flags on attachment: 309169

Committed r216260: <http://trac.webkit.org/changeset/216260>
Comment 11 WebKit Commit Bot 2017-05-05 12:26:44 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 12 Jonathan Bedard 2017-05-05 13:52:39 PDT 
Reverted r216260 for reason:

Breaks internal iOS testers

Committed r216271: <http://trac.webkit.org/changeset/216271>
Comment 13 Jonathan Bedard 2017-05-05 15:06:42 PDT 
Created attachment 309217 [details]
Patch
Comment 14 Jonathan Bedard 2017-05-05 15:07:45 PDT 
Comment on attachment 309217 [details]
Patch

No change to patch.  Just added David Kilzer as the reviewer.  Will be landing again shortly now that Internal bots have been fixed.
Comment 15 Jonathan Bedard 2017-05-05 15:36:33 PDT 
Comment on attachment 309217 [details]
Patch

Confirmed that the Internal bots fix worked.  Sending to commit queue.
Comment 16 WebKit Commit Bot 2017-05-05 15:56:32 PDT 
Comment on attachment 309217 [details]
Patch

Clearing flags on attachment: 309217

Committed r216288: <http://trac.webkit.org/changeset/216288>
Comment 17 WebKit Commit Bot 2017-05-05 15:56:34 PDT 
All reviewed patches have been landed.  Closing bug.