... but the properties don't accept ranges. Therefore, the parser needs to have two ways to parse these keywords.
This includes modifying CSSFontFace to take ranges, and migrating everything off of FontTraitsMask
Created attachment 303602 [details] WIP
Attachment 303602 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
*** Bug 168891 has been marked as a duplicate of this bug. ***
Created attachment 303607 [details] Patch
Comment on attachment 303607 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=303607&action=review > Source/WebCore/css/CSSFontFace.cpp:135 > + auto& value0 = downcast<CSSPrimitiveValue>(*valueList.item(0)); > + auto& value1 = downcast<CSSPrimitiveValue>(*valueList.item(1)); You should probably guard for length == 2, not just ASSERT it.
Committed r213528: <http://trac.webkit.org/changeset/213528>
<rdar://problem/31235144>