Bug 168893 - Parsing font descriptors inside @font-face needs to accept ranges
Summary: Parsing font descriptors inside @font-face needs to accept ranges
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
Keywords: InRadar
: 168891 (view as bug list)
Depends on:
Blocks: 162815
  Show dependency treegraph
Reported: 2017-02-26 21:22 PST by Myles C. Maxfield
Modified: 2017-03-23 21:32 PDT (History)
8 users (show)

See Also:

WIP (27.17 KB, patch)
2017-03-06 18:53 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (43.66 KB, patch)
2017-03-06 19:58 PST, Myles C. Maxfield
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2017-02-26 21:22:27 PST
... but the properties don't accept ranges. Therefore, the parser needs to have two ways to parse these keywords.
Comment 1 Myles C. Maxfield 2017-02-26 21:35:20 PST
This includes modifying CSSFontFace to take ranges, and migrating everything off of FontTraitsMask
Comment 2 Myles C. Maxfield 2017-03-06 18:53:08 PST
Created attachment 303602 [details]
Comment 3 WebKit Commit Bot 2017-03-06 18:54:42 PST
Attachment 303602 [details] did not pass style-queue:

ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 6 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Myles C. Maxfield 2017-03-06 18:56:42 PST
*** Bug 168891 has been marked as a duplicate of this bug. ***
Comment 5 Myles C. Maxfield 2017-03-06 19:58:57 PST
Created attachment 303607 [details]
Comment 6 Dean Jackson 2017-03-07 11:21:45 PST
Comment on attachment 303607 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=303607&action=review

> Source/WebCore/css/CSSFontFace.cpp:135
> +        auto& value0 = downcast<CSSPrimitiveValue>(*valueList.item(0));
> +        auto& value1 = downcast<CSSPrimitiveValue>(*valueList.item(1));

You should probably guard for length == 2, not just ASSERT it.
Comment 7 Myles C. Maxfield 2017-03-07 11:26:29 PST
Committed r213528: <http://trac.webkit.org/changeset/213528>
Comment 8 Radar WebKit Bug Importer 2017-03-23 21:32:07 PDT