Bug 168861 - WebAssembly: miscellaneous spec fixes part deux
Summary: WebAssembly: miscellaneous spec fixes part deux
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: JF Bastien
URL:
Keywords:
Depends on:
Blocks: 159775
  Show dependency treegraph
 
Reported: 2017-02-24 17:39 PST by JF Bastien
Modified: 2017-02-27 10:56 PST (History)
7 users (show)

See Also:


Attachments
patch (17.25 KB, patch)
2017-02-24 17:47 PST, JF Bastien
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description JF Bastien 2017-02-24 17:39:06 PST
More random fixes following bug #168822 (but totally independent).
Comment 1 JF Bastien 2017-02-24 17:47:18 PST
Created attachment 302717 [details]
patch
Comment 2 Keith Miller 2017-02-27 08:27:03 PST
r=me.
Comment 3 WebKit Commit Bot 2017-02-27 08:54:38 PST
Comment on attachment 302717 [details]
patch

Clearing flags on attachment: 302717

Committed r213067: <http://trac.webkit.org/changeset/213067>
Comment 4 WebKit Commit Bot 2017-02-27 08:54:42 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Saam Barati 2017-02-27 10:56:41 PST
Comment on attachment 302717 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302717&action=review

> JSTests/wasm.yaml:136
> +  cmd: runWebAssemblySpecTest :skip # FIXME This test is mostly blocked on implementing re-exporting an import. https://bugs.webkit.org/show_bug.cgi?id=165510

Style nit: "FIXME" should have a colon after it I believe.