WebAssemblyModuleRecord::link has a FIXME to implement it.
<rdar://problem/29760310>
Seems like this error is raised now in http://webassembly.org/demo/.
Created attachment 303980 [details] WIP need to add some tests.
This demo now runs for me: https://kripken.github.io/BananaBread/cube2/bb.html
Created attachment 304013 [details] WIP
Created attachment 304017 [details] WIP I think it's done. Just need some tests now for the wrapper function I added.
Created attachment 304023 [details] patch
Attachment 304023 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/wasm/js/JSWebAssemblyTable.h:32: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 304023 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=304023&action=review r=me. > Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:1064 > + RELEASE_ASSERT(toSave.numberOfSetGPRs() == toSaveSize); I'm not sure this needs to be a release assert.
Created attachment 304072 [details] patch for landing
Created attachment 304073 [details] patch for landing
Attachment 304073 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/wasm/js/JSWebAssemblyTable.h:32: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 304091 [details] patch for landing
Attachment 304091 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/wasm/js/JSWebAssemblyTable.h:32: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 304091 [details] patch for landing Clearing flags on attachment: 304091 Committed r213745: <http://trac.webkit.org/changeset/213745>
All reviewed patches have been landed. Closing bug.