Bug 168820 – [Modern Media Controls] Dragging controls in fullscreen on macOS prevents scrubbing or interacting with controls

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

Dragging controls in fullscreen on macOS prevents scrubbing or interacting with controls.

[Radar WebKit Bug Importer]

<rdar://problem/30690281>

[Antoine Quint]

This regressed with https://bugs.webkit.org/show_bug.cgi?id=168755.

[Antoine Quint]

Created attachment 302635 [details]
Patch

[Jon Lee]

Comment on attachment 302635 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302635&action=review

> Source/WebCore/ChangeLog:12
> +        Since this wasn't caught by our existing tests, we add a test that attemps to initiate a drag

attempts*

> LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html:9
> +description("Testing the <code>MediaController</code> resizing behavior.");

I'd like to see more detailed descriptions here in general, to explain what's going on and what's expected, in words. It makes it easier to understand the intent of the test code, and easier to confirm that this is what the test is doing, when some failure comes down the line. I was also confused by this sentence, because that's not what the code does.

Hence: "This test pauses the video, presses the fullscreen button, and drags the controls when the mouse is over a button. It should not move."

> LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html:19
>  media.addEventListener("webkitfullscreenchange", () => {

Same thing here, please (above, in line 9), except "... It should follow the mouse drag."

[Antoine Quint]

Created attachment 302637 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 302637 [details]
Patch for landing

Clearing flags on attachment: 302637

Committed r212942: <http://trac.webkit.org/changeset/212942>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

This made EWS fail on about half of patches submitted, failing two tests on mac-debug-ews:

New failing tests:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html

Rolling out.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 168882

[Antoine Quint]

This is due to MacOSFullscreenMediaControls not calling this._leftContainer.layout() in its layout() method.

[Antoine Quint]

Committed r213055: <http://trac.webkit.org/changeset/213055>