Bug 168755 - [Modern Media Controls] Clicking on the video doesn't toggle playback state in fullscreen on macOS
Summary: [Modern Media Controls] Clicking on the video doesn't toggle playback state i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-22 16:44 PST by Antoine Quint
Modified: 2017-02-22 18:57 PST (History)
2 users (show)

See Also:

Attachments
Patch (9.89 KB, patch)
2017-02-22 17:54 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2017-02-22 16:44:14 PST 
We added support for clicking on the video to toggle playback on macOS with https://bugs.webkit.org/show_bug.cgi?id=168515, but it doesn't work in fullscreen.
Comment 1 Radar WebKit Bug Importer 2017-02-22 16:45:15 PST 
<rdar://problem/30664484>
Comment 2 Antoine Quint 2017-02-22 17:54:11 PST 
Created attachment 302472 [details]
Patch
Comment 3 WebKit Commit Bot 2017-02-22 18:55:53 PST 
The commit-queue encountered the following flaky tests while processing attachment 302472 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2017-02-22 18:56:12 PST 
The commit-queue encountered the following flaky tests while processing attachment 302472 [details]:

editing/spelling/spellcheck-async.html bug 160571 (authors: g.czajkowski@samsung.com and mark.lam@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2017-02-22 18:57:47 PST 
Comment on attachment 302472 [details]
Patch

Clearing flags on attachment: 302472

Committed r212872: <http://trac.webkit.org/changeset/212872>
Comment 6 WebKit Commit Bot 2017-02-22 18:57:51 PST 
All reviewed patches have been landed.  Closing bug.