Bug 168800 – [Modern Media Controls] No controls are shown for <audio preload="none">

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

We are currently not set to show ANY controls unless .currentSrc returns something other than an empty string. If a media element has the "src" attribute set but "preload" is set to "none" then loading isn’t triggered and .currentSrc isn’t resolved. We should always show the start button for <video> and the controls for <audio> in that case, and hope for the best, although the media may turn out to be invalid.

[Antoine Quint]

<rdar://problem/30652142>

[Antoine Quint]

Created attachment 302611 [details]
Patch

[Build Bot]

Comment on attachment 302611 [details]
Patch

Attachment 302611 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3182208

New failing tests:
fast/regions/inline-block-inside-anonymous-overflow-with-covered-controls.html

[Build Bot]

Created attachment 302622 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 302611 [details]
Patch

Attachment 302611 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3182504

New failing tests:
media/modern-media-controls/volume-down-support/volume-down-support.html

[Build Bot]

Created attachment 302629 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 302646 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 302646 [details]
Patch for landing

Rejecting attachment 302646 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 302646, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
-support-controls-on-audio-expected.txt
patching file LayoutTests/media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-on-audio.html
patching file LayoutTests/media/modern-media-controls/start-support/start-support-no-source-expected.txt
patching file LayoutTests/media/modern-media-controls/start-support/start-support-no-source.html

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3183512

[Antoine Quint]

Created attachment 302648 [details]
Patch for landing

[Antoine Quint]

This made a region test fail and it was set to use legacy media controls instead, see https://bugs.webkit.org/show_bug.cgi?id=168823.

[WebKit Commit Bot]

Comment on attachment 302648 [details]
Patch for landing

Clearing flags on attachment: 302648

Committed r212948: <http://trac.webkit.org/changeset/212948>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.