Bug 168687 – Add missing exception checks detected by running marathon.js.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

When running the marathon.js test from https://bugs.webkit.org/show_bug.cgi?id=168580, we get some crashes due to missing exception checks.  This patch adds those missing exception checks.

[Mark Lam]

Created attachment 302328 [details]
proposed patch.

Let's try this on the EWS.

[Mark Lam]

Comment on attachment 302328 [details]
proposed patch.

It builds.  So, this is ready for a review.

[Saam Barati]

Comment on attachment 302328 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=302328&action=review

> Source/JavaScriptCore/runtime/JSCJSValueInlines.h:652
>      return primitive.toString(exec)->toIdentifier(exec);

what about this?

[Mark Lam]

Comment on attachment 302328 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=302328&action=review

>> Source/JavaScriptCore/runtime/JSCJSValueInlines.h:652
>>      return primitive.toString(exec)->toIdentifier(exec);
> 
> what about this?

I think this is fine.  primitive.toString() will return an empty string here on exception thrown.  Hence, it is safe to call toIdentifier() with it.

[Mark Lam]

Comment on attachment 302328 [details]
proposed patch.

Thanks for the review.  Committing the patch now.

[WebKit Commit Bot]

Comment on attachment 302328 [details]
proposed patch.

Clearing flags on attachment: 302328

Committed r212779: <http://trac.webkit.org/changeset/212779>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.