Bug 168580 – JSC should have a marathon test mode

• Status: NEW
• Component: Tools / Tests

[Filip Pizlo]

JSC tests currently run in a process per test.

But running all tests in one process will help catch more GC bugs because it creates a very polluted heap.

We should run a new test mode, called marathon, that runs a bunch of tests in a single process. It should run concurrently to the other tests.

[Filip Pizlo]

Created attachment 302103 [details]
the patch

It'll be hard to land this because it finds crashes.

[WebKit Commit Bot]

Attachment 302103 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
ERROR: Source/WTF/wtf/NumberOfCores.cpp:53:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Disappointed to see this was not you implementing Bungie's Marathon (https://en.wikipedia.org/wiki/Marathon_(video_game)) in the jsc shell.

[Yusuke Suzuki]

Comment on attachment 302103 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302103&action=review

r=me

> JSTests/stress/marathon.js:14
> +    string = "quit = function() { throw new Error(\"---CALLED-QUIT---\"); }\n" + string;

I recommend to add the stub for `abort()` too.

> Source/JavaScriptCore/jsc.cpp:1372
> +        addFunction(vm, "callInDirectory", functionCallInDirectory, 2);

Let's put `#if !OS(WINDOWS)` things to fix build failure in Windows.

> Source/JavaScriptCore/jsc.cpp:2665
> +    int previousDirectoryFD = open(".", O_RDONLY);

Let's add necessary headers to fix GTK build failures (maybe, `sys/stat.h` and `fcntl.h`.)

> Source/JavaScriptCore/jsc.cpp:2667
> +        int myErrno = errno;

`myErrno` variable can be dropped.

> Source/JavaScriptCore/jsc.cpp:2668
> +        return JSValue::encode(throwException(exec, scope, createError(exec, toString("Cannot open current directory: ", strerror(myErrno)))));

How about using `throwVMError`?

> Source/JavaScriptCore/jsc.cpp:2673
> +        int myErrno = errno;

Ditto.

> Source/JavaScriptCore/jsc.cpp:2674
> +        return JSValue::encode(throwException(exec, scope, createError(exec, toString("Cannot change directory to ", fileName, ": ", strerror(myErrno)))));

Ditto.

> Source/JavaScriptCore/jsc.cpp:2682
> +            return JSValue::encode(throwException(exec, scope, createError(exec, ASCIILiteral("Expected callback"))));

Use throwVMError.