Bug 168672 - WebAssembly: support 0x1 version
Summary: WebAssembly: support 0x1 version
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: JF Bastien
Depends on:
Blocks: 159775 168784 168788
  Show dependency treegraph
Reported: 2017-02-21 13:46 PST by JF Bastien
Modified: 2017-02-23 13:38 PST (History)
7 users (show)

See Also:

patch (1.96 MB, patch)
2017-02-23 10:25 PST, JF Bastien
no flags Details | Formatted Diff | Diff
patch (1.96 MB, patch)
2017-02-23 11:05 PST, JF Bastien
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description JF Bastien 2017-02-21 13:46:21 PST
Other engines are moving to 0x1, so is tooling. We should do the same. IIUC it's just a renumbering.
Comment 1 JF Bastien 2017-02-23 10:25:38 PST
Created attachment 302529 [details]
Comment 2 WebKit Commit Bot 2017-02-23 10:28:20 PST
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".
Comment 3 Keith Miller 2017-02-23 11:00:38 PST
I think we should continue to accept 0xD for now, in addition to 0x1. Otherwise, we will probably break some other tests.
Comment 4 JF Bastien 2017-02-23 11:05:11 PST
Created attachment 302542 [details]

Also support 0xD for now. Removal tracked by bug #168788.
Comment 5 Keith Miller 2017-02-23 11:09:53 PST
r=me on the code/json changes. I'm just going to rubber stamp the test changes.
Comment 6 WebKit Commit Bot 2017-02-23 13:38:05 PST
Comment on attachment 302542 [details]

Clearing flags on attachment: 302542

Committed r212922: <http://trac.webkit.org/changeset/212922>
Comment 7 WebKit Commit Bot 2017-02-23 13:38:09 PST
All reviewed patches have been landed.  Closing bug.