Bug 168323 - [CMake] build-webkit should allow building with the default cmake configuration
Summary: [CMake] build-webkit should allow building with the default cmake configuration
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords:
Depends on:
Blocks: 168321
  Show dependency treegraph
 
Reported: 2017-02-14 08:24 PST by Carlos Alberto Lopez Perez
Modified: 2017-02-14 10:10 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.49 KB, patch)
2017-02-14 08:40 PST, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff
Patch (2.67 KB, patch)
2017-02-14 09:43 PST, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2017-02-14 08:24:36 PST
When using the build-webkit script its currently not possible to use the default features enabled on the cmake configuration for the port.

The --minimal option disabled all optional features.

I propose adding a --default option that build the CMake port without specifying any value for the features, that way the default value from the cmake config will be used.


This will be needed for the new bots we plan to add on bug 168321
Comment 1 Michael Catanzaro 2017-02-14 08:30:22 PST
You need to come up with a better name than --default. We can't have a --default flag that changes all the arguments to something that's not default for build-webkit, that would be super confusing. :)

Maybe --disable-developer-options?
Comment 2 Carlos Alberto Lopez Perez 2017-02-14 08:40:00 PST
Created attachment 301505 [details]
Patch
Comment 3 Carlos Alberto Lopez Perez 2017-02-14 09:43:16 PST
Created attachment 301515 [details]
Patch

Use --default-cmake-features for this
Comment 4 Michael Catanzaro 2017-02-14 09:48:22 PST
Comment on attachment 301515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301515&action=review

This is great! Now build-webkit will actually be useful. :)

> Tools/Scripts/build-webkit:55
> +my $defaultCmakeFeatures = 0;

$defaultCMakeFeatures
Comment 5 Carlos Alberto Lopez Perez 2017-02-14 10:09:23 PST
Committed r212306: <http://trac.webkit.org/changeset/212306>