Bug 168323 – [CMake] build-webkit should allow building with the default cmake configuration

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Alberto Lopez Perez]

When using the build-webkit script its currently not possible to use the default features enabled on the cmake configuration for the port.

The --minimal option disabled all optional features.

I propose adding a --default option that build the CMake port without specifying any value for the features, that way the default value from the cmake config will be used.


This will be needed for the new bots we plan to add on bug 168321

[Michael Catanzaro]

You need to come up with a better name than --default. We can't have a --default flag that changes all the arguments to something that's not default for build-webkit, that would be super confusing. :)

Maybe --disable-developer-options?

[Carlos Alberto Lopez Perez]

Created attachment 301505 [details]
Patch

[Carlos Alberto Lopez Perez]

Created attachment 301515 [details]
Patch

Use --default-cmake-features for this

[Michael Catanzaro]

Comment on attachment 301515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301515&action=review

This is great! Now build-webkit will actually be useful. :)

> Tools/Scripts/build-webkit:55
> +my $defaultCmakeFeatures = 0;

$defaultCMakeFeatures

[Carlos Alberto Lopez Perez]

Committed r212306: <http://trac.webkit.org/changeset/212306>