Bug 168318 - [CMake] build-webkit should print the cmake command executed
Summary: [CMake] build-webkit should print the cmake command executed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-14 07:36 PST by Carlos Alberto Lopez Perez
Modified: 2017-02-14 08:48 PST (History)
9 users (show)

See Also:

Attachments
Patch (2.54 KB, patch)
2017-02-14 07:46 PST, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2017-02-14 07:36:50 PST 
When using the script build-webkit, is not obvious at all what we end passing to the CMake build system.

On one hand I think it should be easy to see that info. 

On the other hand, I find this info very valuable to be fully aware of what options we (and the bots) build and how (actually I'm really surprised to discover that on the GTK+ port we are passing more than 90 parameters to CMake on the release build)

So I propose that we print the CMake commands that we are going to run on stdout.


I think this don't adds unneeded extra noise, it only prints one extra line (a long one when starting from a clean build state) each time you run the build-webkit script.
Comment 1 Carlos Alberto Lopez Perez 2017-02-14 07:46:50 PST 
Created attachment 301499 [details]
Patch
Comment 2 WebKit Commit Bot 2017-02-14 08:48:28 PST 
Comment on attachment 301499 [details]
Patch

Clearing flags on attachment: 301499

Committed r212298: <http://trac.webkit.org/changeset/212298>
Comment 3 WebKit Commit Bot 2017-02-14 08:48:33 PST 
All reviewed patches have been landed.  Closing bug.