Bug 168026 - Update web-platform-tests resources
Summary: Update web-platform-tests resources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 167964
  Show dependency treegraph
 
Reported: 2017-02-08 16:02 PST by Chris Dumez
Modified: 2017-02-09 10:56 PST (History)
7 users (show)

See Also:


Attachments
Patch (507.32 KB, patch)
2017-02-08 16:08 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (507.31 KB, patch)
2017-02-08 16:29 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (733.94 KB, patch)
2017-02-08 19:13 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (738.52 KB, application/zip)
2017-02-08 20:31 PST, Build Bot
no flags Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.01 MB, application/zip)
2017-02-08 20:34 PST, Build Bot
no flags Details
Archive of layout-test-results from ews114 for mac-elcapitan (1.49 MB, application/zip)
2017-02-08 20:36 PST, Build Bot
no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (877.34 KB, application/zip)
2017-02-08 20:39 PST, Build Bot
no flags Details
Patch (739.42 KB, patch)
2017-02-08 20:43 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (739.42 KB, patch)
2017-02-08 21:02 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-02-08 16:02:29 PST
Update web-platform-tests resources.
Comment 1 Chris Dumez 2017-02-08 16:08:06 PST
Created attachment 300981 [details]
Patch
Comment 2 Chris Dumez 2017-02-08 16:29:56 PST
Created attachment 300983 [details]
Patch
Comment 3 Alexey Proskuryakov 2017-02-08 17:04:48 PST
Just to confirm, we are not starting to download the resources from the web again, are we?
Comment 4 Chris Dumez 2017-02-08 17:05:47 PST
(In reply to comment #3)
> Just to confirm, we are not starting to download the resources from the web
> again, are we?

The opposite, I am checking in the extracted files in the tree, just as you suggested (although I am only checking in some of them for now).
Comment 5 Alexey Proskuryakov 2017-02-08 17:19:06 PST
Thanks! 

> although I am only checking in some of them for now 

This is what confused me. There were so few files, so that I was afraid that there was some implicit fallback activated, not visible in the patch.
Comment 6 Chris Dumez 2017-02-08 19:13:23 PST
Created attachment 300997 [details]
Patch
Comment 7 Chris Dumez 2017-02-08 19:14:13 PST
I'll update the testharness.js in LayoutTests/resources/ in a follow-up to reduce patch size.
Comment 8 Build Bot 2017-02-08 20:31:46 PST
Comment on attachment 300997 [details]
Patch

Attachment 300997 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3029719

New failing tests:
imported/w3c/web-platform-tests/XMLHttpRequest/response-method.htm
imported/w3c/web-platform-tests/XMLHttpRequest/send-network-error-sync-events.sub.htm
Comment 9 Build Bot 2017-02-08 20:31:50 PST
Created attachment 301005 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 10 Build Bot 2017-02-08 20:34:48 PST
Comment on attachment 300997 [details]
Patch

Attachment 300997 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3029695

New failing tests:
imported/w3c/web-platform-tests/XMLHttpRequest/response-method.htm
Comment 11 Build Bot 2017-02-08 20:34:52 PST
Created attachment 301006 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 12 Build Bot 2017-02-08 20:36:06 PST
Comment on attachment 300997 [details]
Patch

Attachment 300997 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3029707

New failing tests:
imported/w3c/web-platform-tests/XMLHttpRequest/response-method.htm
imported/w3c/web-platform-tests/XMLHttpRequest/send-network-error-sync-events.sub.htm
Comment 13 Build Bot 2017-02-08 20:36:10 PST
Created attachment 301007 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 14 Build Bot 2017-02-08 20:39:50 PST
Comment on attachment 300997 [details]
Patch

Attachment 300997 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3029696

New failing tests:
imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-cross-origin.html
imported/w3c/web-platform-tests/html/dom/reflection-embedded.html
Comment 15 Build Bot 2017-02-08 20:39:55 PST
Created attachment 301008 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 16 Chris Dumez 2017-02-08 20:43:40 PST
Created attachment 301009 [details]
Patch
Comment 17 Chris Dumez 2017-02-08 21:02:17 PST
Created attachment 301011 [details]
Patch
Comment 18 Chris Dumez 2017-02-08 21:53:40 PST
Comment on attachment 301011 [details]
Patch

Clearing flags on attachment: 301011

Committed r211930: <http://trac.webkit.org/changeset/211930>
Comment 19 Chris Dumez 2017-02-08 21:53:46 PST
All reviewed patches have been landed.  Closing bug.
Comment 20 Michael Catanzaro 2017-02-09 10:38:45 PST
Looks like this introduced ~50 test failures on GTK port. :(
Comment 21 Chris Dumez 2017-02-09 10:54:32 PST
(In reply to comment #20)
> Looks like this introduced ~50 test failures on GTK port. :(

I already explained on IRC that this is because the bot has a SVN conflict that needs to be resolved. The bot is still running the tests with the old testharness.js.

We did a svn cleanup on the Mac bots to fix the failures.
Comment 22 Chris Dumez 2017-02-09 10:56:02 PST
(In reply to comment #21)
> (In reply to comment #20)
> > Looks like this introduced ~50 test failures on GTK port. :(
> 
> I already explained on IRC that this is because the bot has a SVN conflict
> that needs to be resolved. The bot is still running the tests with the old
> testharness.js.
> 
> We did a svn cleanup on the Mac bots to fix the failures.

See your GTK bot:
https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/20721/steps/svn/logs/stdio

In particular:
   C LayoutTests/imported/w3c/web-platform-tests/resources
   A LayoutTests/imported/w3c/web-platform-tests/resources/webidl2
   A LayoutTests/imported/w3c/web-platform-tests/resources/webidl2/lib
   A LayoutTests/imported/w3c/web-platform-tests/resources/webidl2/lib/webidl2.js

C stands for conflict.