Bug 167964 - Object.getPrototypeOf(NodeFilter) should be Function.prototype, not Object.prototype
Summary: Object.getPrototypeOf(NodeFilter) should be Function.prototype, not Object.pr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://github.com/heycam/webidl/issu...
Keywords:
Depends on: 168026
Blocks:
  Show dependency tree / graph
 
Reported: 2017-02-07 16:20 PST by Chris Dumez
Modified: 2017-02-09 10:56 PST (History)
8 users (show)

See Also:

Attachments
WIP Patch (4.94 KB, patch)
2017-02-07 16:49 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (987.72 KB, application/zip)
2017-02-07 17:56 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews117 for mac-elcapitan (1.64 MB, application/zip)
2017-02-07 18:05 PST, Build Bot 		no flags Details
Patch (9.13 KB, patch)
2017-02-09 09:57 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-02-07 16:20:08 PST 
NodeFilter's [[Prototype]] should be %FunctionPrototype%, not %ObjectPrototype%. The Web IDL specification on this has changed recently:
- https://heycam.github.io/webidl/#interface-object
Comment 1 Chris Dumez 2017-02-07 16:49:51 PST 
Created attachment 300858 [details]
WIP Patch
Comment 2 Build Bot 2017-02-07 17:56:53 PST 
Comment on attachment 300858 [details]
WIP Patch

Attachment 300858 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3022402

New failing tests:
http/tests/security/cross-frame-access-put.html
Comment 3 Build Bot 2017-02-07 17:56:57 PST 
Created attachment 300866 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-02-07 18:05:19 PST 
Comment on attachment 300858 [details]
WIP Patch

Attachment 300858 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3022409

New failing tests:
http/tests/security/cross-frame-access-put.html
Comment 5 Build Bot 2017-02-07 18:05:22 PST 
Created attachment 300870 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Chris Dumez 2017-02-09 09:57:20 PST 
Created attachment 301053 [details]
Patch
Comment 7 WebKit Commit Bot 2017-02-09 10:56:00 PST 
Comment on attachment 301053 [details]
Patch

Clearing flags on attachment: 301053

Committed r211970: <http://trac.webkit.org/changeset/211970>
Comment 8 WebKit Commit Bot 2017-02-09 10:56:06 PST 
All reviewed patches have been landed.  Closing bug.