A <video> element that doesn't contain any video tracks still turns on auto-hide for the controls and shows a fullscreen button. This shouldn't be the case.
<rdar://problem/30255812>
Created attachment 300675 [details] Patch
Comment on attachment 300675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300675&action=review > Source/WebCore/ChangeLog:9 > + We now check for the availability of video tracks before considerig a <video> Typo: considering > Source/WebCore/ChangeLog:13 > + to be the same as an <audio> element. Did you check this with a media document? Which always uses video, even for audio content.
(In reply to comment #3) > Comment on attachment 300675 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=300675&action=review > > > Source/WebCore/ChangeLog:9 > > + We now check for the availability of video tracks before considerig a <video> > > Typo: considering > > > Source/WebCore/ChangeLog:13 > > + to be the same as an <audio> element. > > Did you check this with a media document? Which always uses video, even for > audio content. Yes, that's how I found out about this bug :)
Created attachment 300676 [details] Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 300676 [details]: The commit-queue is continuing to process your patch.
Comment on attachment 300676 [details] Patch for landing Rejecting attachment 300676 [details] from commit-queue. New failing tests: media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-on.html media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-toggle.html fast/regions/inline-block-inside-anonymous-overflow-with-covered-controls.html Full output: http://webkit-queues.webkit.org/results/3011053
Created attachment 300681 [details] Archive of layout-test-results from webkit-cq-03 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-03 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 300702 [details] Patch for landing
Created attachment 300703 [details] Patch for landing
Comment on attachment 300703 [details] Patch for landing Attachment 300703 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3013185 New failing tests: media/modern-media-controls/time-label/time-label-white-space-nowrap.html
Created attachment 300709 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 300711 [details] Patch for landing
Comment on attachment 300711 [details] Patch for landing Clearing flags on attachment: 300711 Committed r211722: <http://trac.webkit.org/changeset/211722>
All reviewed patches have been landed. Closing bug.
(In reply to comment #14) > Comment on attachment 300711 [details] > Patch for landing > > Clearing flags on attachment: 300711 > > Committed r211722: <http://trac.webkit.org/changeset/211722> This change caused fast/regions/inline-block-inside-anonymous-overflow-with-covered-controls.html to fail on mac-wk2: https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r211724%20(3315)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fregions%2Finline-block-inside-anonymous-overflow-with-covered-controls.html
Reverted r211722 for reason: This change introduced a LayoutTest failure on mac-wk2. Committed r211729: <http://trac.webkit.org/changeset/211729>
This is an image reference mismatch issue. Investigating.
Created attachment 300797 [details] Patch for landing
Comment on attachment 300797 [details] Patch for landing Clearing flags on attachment: 300797 Committed r211802: <http://trac.webkit.org/changeset/211802>
Reverted r211802 for reason: This change caused fast/regions/inline-block-inside-anonymous-overflow-with-covered-controls.html to be a flaky failure. Committed r211986: <http://trac.webkit.org/changeset/211986>
(In reply to comment #22) > Reverted r211802 for reason: > > This change caused > fast/regions/inline-block-inside-anonymous-overflow-with-covered-controls. > html to be a flaky failure. > > Committed r211986: <http://trac.webkit.org/changeset/211986> See https://bugs.webkit.org/show_bug.cgi?id=167976
*** Bug 167976 has been marked as a duplicate of this bug. ***
Fixing https://bugs.webkit.org/show_bug.cgi?id=168506 will address the flakiness of fast/regions/inline-block-inside-anonymous-overflow-with-covered-controls.html without any further source changes. Will re-land once that bug is fixed.
Committed r212575: <http://trac.webkit.org/changeset/212575>