Bug 167356 – [GTK] Web Inspector: Add new GTK+ icons for garbage collect and clean buttons in Console

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Add new GTK+ icons for garbage collect and clean buttons in Console

Images:

    UserInterface/Images/NavigationItemClear.svg
    UserInterface/Images/NavigationItemGarbageCollect.svg

Notes:
- These icons are used in the Console's Navigator bar.
- Current "Clear" was copied from "Trash" but should be designed for 16x16. (It currently is, but is used at 15x15 because it looks better and seems intended that way).
- See bug 167345

[Fujii Hironori]

Created attachment 311109 [details]
Patch

[Fujii Hironori]

Created attachment 311110 [details]
screenshot of before and after this fix

[Michael Catanzaro]

Comment on attachment 311109 [details]
Patch

Weird, our old icons were 15x15? I've never heard of such an icon size before....

[WebKit Commit Bot]

Comment on attachment 311109 [details]
Patch

Clearing flags on attachment: 311109

Committed r217386: <http://trac.webkit.org/changeset/217386>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Fujii Hironori]

Thank you for the review.

(In reply to Michael Catanzaro from comment #3)
> Weird, our old icons were 15x15? I've never heard of such an icon size
> before....

Right. it has been 16x16.
NavigationItemClear.svg has three 1-unit-width vertical lines in the image.
But, this lines were not aligned with dot grid. It were rendered blued 2-px-width lines if the image is rendered 16px dimension. This is why Joseph resized it to 15px dimension.
Then, I shifted 0.5 unit left in this change.

[Radar WebKit Bug Importer]

<rdar://problem/32479873>