Bug 167345 - Web Inspector: Provide a way to trigger a Garbage Collection
Summary: Web Inspector: Provide a way to trigger a Garbage Collection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-23 17:19 PST by Joseph Pecoraro
Modified: 2017-01-23 19:20 PST (History)
14 users (show)

See Also:

Attachments
[IMAGE] Garbage Collect button in Console - New Clear Icon (231.50 KB, image/png)
2017-01-23 17:27 PST, Joseph Pecoraro 		no flags Details
[PATCH] Proposed Fix (126.58 KB, patch)
2017-01-23 17:27 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-01-23 17:19:34 PST 
Summary:
Provide a way to trigger a Garbage Collection

Sometimes developers want to just perform a GC. We already have the capability, we should expose a button in Web Inspector to do this.
Comment 1 Joseph Pecoraro 2017-01-23 17:20:04 PST 
<rdar://problem/30102853>
Comment 2 Joseph Pecoraro 2017-01-23 17:27:40 PST 
Created attachment 299560 [details]
[IMAGE] Garbage Collect button in Console - New Clear Icon
Comment 3 Joseph Pecoraro 2017-01-23 17:27:59 PST 
Created attachment 299561 [details]
[PATCH] Proposed Fix
Comment 4 WebKit Commit Bot 2017-01-23 17:30:55 PST 
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 5 Timothy Hatcher 2017-01-23 17:34:15 PST 
Comment on attachment 299561 [details]
[PATCH] Proposed Fix

I like the clear icon, but I wasn't sure about the collect icon. I'm blank on ideas though. Memory chip half full?
Comment 6 WebKit Commit Bot 2017-01-23 19:20:21 PST 
Comment on attachment 299561 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 299561

Committed r211075: <http://trac.webkit.org/changeset/211075>
Comment 7 WebKit Commit Bot 2017-01-23 19:20:27 PST 
All reviewed patches have been landed.  Closing bug.