Created attachment 298488 [details] [SCREENSHOT] the bug These should never be hidden by the [E] path components, but it seems they lose out while we could have made an Element path component description much shorter.
<rdar://problem/29951737>
This was broken a month ago by Bug 165745: Web Inspector: Cleanup HierarchicalPathComponent. https://trac.webkit.org/changeset/209711/trunk
Created attachment 298734 [details] Patch
Comment on attachment 298734 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298734&action=review > Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js:216 > - this._element.classList.toggle("show-selector-arrows", this._selectorArrows); > + this._element.classList.toggle("show-selector-arrows", Boolean(this._selectorArrows)); Perhaps doing !!this._selectorArrows would be better?
Created attachment 298736 [details] Patch
(In reply to comment #4) > Comment on attachment 298734 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=298734&action=review > > > Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js:216 > > - this._element.classList.toggle("show-selector-arrows", this._selectorArrows); > > + this._element.classList.toggle("show-selector-arrows", Boolean(this._selectorArrows)); > > Perhaps doing !!this._selectorArrows would be better? Indeed!
Created attachment 298737 [details] Patch
Comment on attachment 298737 [details] Patch Clearing flags on attachment: 298737 Committed r210691: <http://trac.webkit.org/changeset/210691>
All reviewed patches have been landed. Closing bug.