Bug 166898 - REGRESSION (r209711): Web Inspector: in Elements Tab, selecting a deeply nested DOM element causes navigation bar buttons to be pushed off the leading edge
Summary: REGRESSION (r209711): Web Inspector: in Elements Tab, selecting a deeply nest...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P1 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-10 11:19 PST by BJ Burg
Modified: 2017-01-12 17:31 PST (History)
4 users (show)

See Also:


Attachments
[SCREENSHOT] the bug (291.44 KB, image/png)
2017-01-10 11:19 PST, BJ Burg
no flags Details
Patch (1.84 KB, patch)
2017-01-12 16:40 PST, Nikita Vasilyev
timothy: review+
Details | Formatted Diff | Diff
Patch (1.83 KB, patch)
2017-01-12 16:48 PST, Nikita Vasilyev
no flags Details | Formatted Diff | Diff
Patch (1.84 KB, patch)
2017-01-12 16:50 PST, Nikita Vasilyev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-01-10 11:19:12 PST
Created attachment 298488 [details]
[SCREENSHOT] the bug

These should never be hidden by the [E] path components, but it seems they lose out while we could have made an Element path component description much shorter.
Comment 1 Radar WebKit Bug Importer 2017-01-10 11:20:08 PST
<rdar://problem/29951737>
Comment 2 Nikita Vasilyev 2017-01-12 14:58:14 PST
This was broken a month ago by Bug 165745: Web Inspector: Cleanup HierarchicalPathComponent.

https://trac.webkit.org/changeset/209711/trunk
Comment 3 Nikita Vasilyev 2017-01-12 16:40:05 PST
Created attachment 298734 [details]
Patch
Comment 4 Timothy Hatcher 2017-01-12 16:42:34 PST
Comment on attachment 298734 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298734&action=review

> Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js:216
> -        this._element.classList.toggle("show-selector-arrows", this._selectorArrows);
> +        this._element.classList.toggle("show-selector-arrows", Boolean(this._selectorArrows));

Perhaps doing !!this._selectorArrows would be better?
Comment 5 Nikita Vasilyev 2017-01-12 16:48:26 PST
Created attachment 298736 [details]
Patch
Comment 6 Nikita Vasilyev 2017-01-12 16:49:11 PST
(In reply to comment #4)
> Comment on attachment 298734 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=298734&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js:216
> > -        this._element.classList.toggle("show-selector-arrows", this._selectorArrows);
> > +        this._element.classList.toggle("show-selector-arrows", Boolean(this._selectorArrows));
> 
> Perhaps doing !!this._selectorArrows would be better?

Indeed!
Comment 7 Nikita Vasilyev 2017-01-12 16:50:03 PST
Created attachment 298737 [details]
Patch
Comment 8 WebKit Commit Bot 2017-01-12 17:31:07 PST
Comment on attachment 298737 [details]
Patch

Clearing flags on attachment: 298737

Committed r210691: <http://trac.webkit.org/changeset/210691>
Comment 9 WebKit Commit Bot 2017-01-12 17:31:11 PST
All reviewed patches have been landed.  Closing bug.