Modernize and tidy up code, remove single use CSS class name constants, and back all properties by the model not the DOM.
Created attachment 296888 [details] Patch
Comment on attachment 296888 [details] Patch r=me
Comment on attachment 296888 [details] Patch Clearing flags on attachment: 296888 Committed r209711: <http://trac.webkit.org/changeset/209711>
All reviewed patches have been landed. Closing bug.
Comment on attachment 296888 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296888&action=review > Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js:96 > + get element() { return this._element; } > + get representedObject() { return this._representedObject; } I still think we shouldn't have one line getters/setters in the middle of a list of getters/setters. I think they should be at the top.
(In reply to comment #5) > Comment on attachment 296888 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=296888&action=review > > > Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js:96 > > + get element() { return this._element; } > > + get representedObject() { return this._representedObject; } > > I still think we shouldn't have one line getters/setters in the middle of a > list of getters/setters. I think they should be at the top. I am indifferent. Can you update the style guide if it's not in there already?