RESOLVED FIXED 165745
Web Inspector: Cleanup HierarchicalPathComponent 
https://bugs.webkit.org/show_bug.cgi?id=165745
Summary Web Inspector: Cleanup HierarchicalPathComponent
Matt Baker
Reported 2016-12-11 18:16:20 PST
Modernize and tidy up code, remove single use CSS class name constants, and back all properties by the model not the DOM.
Attachments
Patch (11.54 KB, patch)
2016-12-11 18:23 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2016-12-11 18:23:54 PST
Created attachment 296888 [details] Patch
Blaze Burg
Comment 2 2016-12-12 09:22:13 PST
Comment on attachment 296888 [details] Patch r=me
WebKit Commit Bot
Comment 3 2016-12-12 09:24:36 PST
Comment on attachment 296888 [details] Patch Clearing flags on attachment: 296888 Committed r209711: <http://trac.webkit.org/changeset/209711>
WebKit Commit Bot
Comment 4 2016-12-12 09:24:39 PST
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 5 2016-12-12 10:16:21 PST
Comment on attachment 296888 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296888&action=review > Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js:96 > + get element() { return this._element; } > + get representedObject() { return this._representedObject; } I still think we shouldn't have one line getters/setters in the middle of a list of getters/setters. I think they should be at the top.
Blaze Burg
Comment 6 2016-12-12 10:18:43 PST
(In reply to comment #5) > Comment on attachment 296888 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=296888&action=review > > > Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js:96 > > + get element() { return this._element; } > > + get representedObject() { return this._representedObject; } > > I still think we shouldn't have one line getters/setters in the middle of a > list of getters/setters. I think they should be at the top. I am indifferent. Can you update the style guide if it's not in there already?
Note You need to log in before you can comment on or make changes to this bug.