Bug 166874 - JSArray has some object scanning races
Summary: JSArray has some object scanning races
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
: 166795 (view as bug list)
Depends on:
Blocks: 165909
  Show dependency tree / graph
 
Reported: 2017-01-09 19:27 PST by Filip Pizlo
Modified: 2017-01-13 16:07 PST (History)
7 users (show)

See Also:

Attachments
the patch (7.52 KB, patch)
2017-01-09 20:03 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (8.73 KB, patch)
2017-01-09 20:05 PST, Filip Pizlo 		mark.lam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-01-09 19:27:47 PST 
Fix them with locks!
Comment 1 Radar WebKit Bug Importer 2017-01-09 19:28:08 PST 
<rdar://problem/29941356>
Comment 2 Filip Pizlo 2017-01-09 20:03:26 PST 
Created attachment 298436 [details]
the patch
Comment 3 Filip Pizlo 2017-01-09 20:05:17 PST 
Created attachment 298437 [details]
the patch
Comment 4 Mark Lam 2017-01-09 23:17:39 PST 
Comment on attachment 298437 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298437&action=review

r=me

> Source/JavaScriptCore/runtime/JSArray.cpp:1081
> -
> +    

Please undo this empty space change.
Comment 5 Filip Pizlo 2017-01-10 10:39:30 PST 
(In reply to comment #4)
> Comment on attachment 298437 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=298437&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/runtime/JSArray.cpp:1081
> > -
> > +    
> 
> Please undo this empty space change.

Fixed!
Comment 6 Filip Pizlo 2017-01-10 10:46:07 PST 
Landed in https://trac.webkit.org/changeset/210553
Comment 7 Mark Lam 2017-01-13 16:07:57 PST 
*** Bug 166795 has been marked as a duplicate of this bug. ***