Bug 166866 - Measure how common it is for content to deal with WebGL context loss
Summary: Measure how common it is for content to deal with WebGL context loss
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://www.khronos.org/webgl/wiki/Ha...
Keywords: InRadar
Depends on: 166730
Blocks:
  Show dependency tree / graph
 
Reported: 2017-01-09 15:34 PST by Chris Dumez
Modified: 2017-01-25 09:52 PST (History)
9 users (show)

See Also:

Attachments
WIP Patch (2.88 KB, patch)
2017-01-09 15:43 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (7.40 KB, patch)
2017-01-24 12:21 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (7.40 KB, patch)
2017-01-24 12:25 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews113 for mac-elcapitan (1.62 MB, application/zip)
2017-01-24 13:57 PST, Build Bot 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-01-09 15:34:27 PST 
Measure how common it is for content to deal with WebGL context loss.
Comment 1 Chris Dumez 2017-01-09 15:34:42 PST 
<rdar://problem/29883469>
Comment 2 Chris Dumez 2017-01-09 15:43:44 PST 
Created attachment 298403 [details]
WIP Patch
Comment 3 Chris Dumez 2017-01-24 12:21:45 PST 
Created attachment 299614 [details]
Patch
Comment 4 Chris Dumez 2017-01-24 12:25:15 PST 
<rdar://problem/30171195>
Comment 5 Chris Dumez 2017-01-24 12:25:54 PST 
Created attachment 299616 [details]
Patch
Comment 6 Build Bot 2017-01-24 13:57:07 PST 
Comment on attachment 299616 [details]
Patch

Attachment 299616 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2942573

New failing tests:
media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html
Comment 7 Build Bot 2017-01-24 13:57:12 PST 
Created attachment 299628 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 8 Alex Christensen 2017-01-25 00:18:46 PST 
Comment on attachment 299616 [details]
Patch

r=me
Should we also measure how often a contextLoss handler would have been called if it were present/is called if it is present?
Comment 9 Chris Dumez 2017-01-25 09:26:38 PST 
(In reply to comment #8)
> Comment on attachment 299616 [details]
> Patch
> 
> r=me
> Should we also measure how often a contextLoss handler would have been
> called if it were present/is called if it is present?

I don't think this is important at the moment. What we want to know is would it be safe for us to take away / restore the WebGL context and rely on the pages dealing with context loss via those event handlers.
Comment 10 WebKit Commit Bot 2017-01-25 09:52:31 PST 
Comment on attachment 299616 [details]
Patch

Clearing flags on attachment: 299616

Committed r211151: <http://trac.webkit.org/changeset/211151>
Comment 11 WebKit Commit Bot 2017-01-25 09:52:37 PST 
All reviewed patches have been landed.  Closing bug.