Bug 166730 - [WK2] Add diagnostic logging to measure WebGL usage
Summary: [WK2] Add diagnostic logging to measure WebGL usage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 166866
  Show dependency tree / graph
 
Reported: 2017-01-05 09:08 PST by Chris Dumez
Modified: 2017-01-13 21:54 PST (History)
15 users (show)

See Also:

Attachments
Patch (38.63 KB, patch)
2017-01-09 11:02 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (38.63 KB, patch)
2017-01-09 14:25 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (39.12 KB, patch)
2017-01-09 15:37 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (39.15 KB, patch)
2017-01-09 15:52 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (39.15 KB, patch)
2017-01-13 16:45 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-01-05 09:08:56 PST 
Add diagnostic logging to measure WebGL usage.
Comment 1 Chris Dumez 2017-01-05 09:09:17 PST 
<rdar://problem/29883469>
Comment 2 Chris Dumez 2017-01-09 11:02:11 PST 
Created attachment 298367 [details]
Patch
Comment 3 WebKit Commit Bot 2017-01-09 11:03:20 PST 
Attachment 298367 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/WebGLStateTracker.cpp:33:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Chris Dumez 2017-01-09 14:25:49 PST 
Created attachment 298390 [details]
Patch
Comment 5 WebKit Commit Bot 2017-01-09 14:27:53 PST 
Attachment 298390 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/WebGLStateTracker.cpp:33:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Chris Dumez 2017-01-09 15:37:52 PST 
Created attachment 298402 [details]
Patch
Comment 7 WebKit Commit Bot 2017-01-09 15:40:47 PST 
Attachment 298402 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/WebGLStateTracker.cpp:33:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Chris Dumez 2017-01-09 15:52:55 PST 
Created attachment 298407 [details]
Patch
Comment 9 WebKit Commit Bot 2017-01-09 15:55:22 PST 
Attachment 298407 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/WebGLStateTracker.cpp:33:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Chris Dumez 2017-01-13 14:58:00 PST 
ping review?
Comment 11 Alex Christensen 2017-01-13 16:19:33 PST 
Comment on attachment 298407 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298407&action=review

> Source/WebCore/platform/WebGLStateTracker.cpp:42
> +    return m_WebGLContextCounter.count();

W should probably be lowercase.
Comment 12 Chris Dumez 2017-01-13 16:45:55 PST 
Created attachment 298808 [details]
Patch
Comment 13 WebKit Commit Bot 2017-01-13 16:48:51 PST 
Attachment 298808 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/WebGLStateTracker.cpp:33:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 14 WebKit Commit Bot 2017-01-13 17:06:38 PST 
Comment on attachment 298808 [details]
Patch

Clearing flags on attachment: 298808

Committed r210753: <http://trac.webkit.org/changeset/210753>
Comment 15 WebKit Commit Bot 2017-01-13 17:06:44 PST 
All reviewed patches have been landed.  Closing bug.
Comment 16 Alex Christensen 2017-01-13 21:54:01 PST 
r210762