WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
166730
[WK2] Add diagnostic logging to measure WebGL usage
https://bugs.webkit.org/show_bug.cgi?id=166730
Summary
[WK2] Add diagnostic logging to measure WebGL usage
Chris Dumez
Reported
2017-01-05 09:08:56 PST
Add diagnostic logging to measure WebGL usage.
Attachments
Patch
(38.63 KB, patch)
2017-01-09 11:02 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(38.63 KB, patch)
2017-01-09 14:25 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(39.12 KB, patch)
2017-01-09 15:37 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(39.15 KB, patch)
2017-01-09 15:52 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(39.15 KB, patch)
2017-01-13 16:45 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2017-01-05 09:09:17 PST
<
rdar://problem/29883469
>
Chris Dumez
Comment 2
2017-01-09 11:02:11 PST
Created
attachment 298367
[details]
Patch
WebKit Commit Bot
Comment 3
2017-01-09 11:03:20 PST
Attachment 298367
[details]
did not pass style-queue: ERROR: Source/WebCore/platform/WebGLStateTracker.cpp:33: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 4
2017-01-09 14:25:49 PST
Created
attachment 298390
[details]
Patch
WebKit Commit Bot
Comment 5
2017-01-09 14:27:53 PST
Attachment 298390
[details]
did not pass style-queue: ERROR: Source/WebCore/platform/WebGLStateTracker.cpp:33: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 6
2017-01-09 15:37:52 PST
Created
attachment 298402
[details]
Patch
WebKit Commit Bot
Comment 7
2017-01-09 15:40:47 PST
Attachment 298402
[details]
did not pass style-queue: ERROR: Source/WebCore/platform/WebGLStateTracker.cpp:33: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 8
2017-01-09 15:52:55 PST
Created
attachment 298407
[details]
Patch
WebKit Commit Bot
Comment 9
2017-01-09 15:55:22 PST
Attachment 298407
[details]
did not pass style-queue: ERROR: Source/WebCore/platform/WebGLStateTracker.cpp:33: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 10
2017-01-13 14:58:00 PST
ping review?
Alex Christensen
Comment 11
2017-01-13 16:19:33 PST
Comment on
attachment 298407
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=298407&action=review
> Source/WebCore/platform/WebGLStateTracker.cpp:42 > + return m_WebGLContextCounter.count();
W should probably be lowercase.
Chris Dumez
Comment 12
2017-01-13 16:45:55 PST
Created
attachment 298808
[details]
Patch
WebKit Commit Bot
Comment 13
2017-01-13 16:48:51 PST
Attachment 298808
[details]
did not pass style-queue: ERROR: Source/WebCore/platform/WebGLStateTracker.cpp:33: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 14
2017-01-13 17:06:38 PST
Comment on
attachment 298808
[details]
Patch Clearing flags on attachment: 298808 Committed
r210753
: <
http://trac.webkit.org/changeset/210753
>
WebKit Commit Bot
Comment 15
2017-01-13 17:06:44 PST
All reviewed patches have been landed. Closing bug.
Alex Christensen
Comment 16
2017-01-13 21:54:01 PST
r210762
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug