WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
166701
WebAssembly: Module.customSections test copying
https://bugs.webkit.org/show_bug.cgi?id=166701
Summary
WebAssembly: Module.customSections test copying
JF Bastien
Reported
2017-01-04 15:46:22 PST
In
bug #165159
I forgot to check that the ArrayBuffer obtained is always a new object, not a view onto the old. This is important because modifying the ArrayBuffer shouldn't modify the original custom section (there would also be lifetime issues).
Attachments
Add attachment
proposed patch, testcase, etc.
Sergey Rubanov
Comment 1
2026-07-22 13:22:27 PDT
https://github.com/WebKit/WebKit/pull/69958
Sergey Rubanov
Comment 2
2026-07-22 13:31:59 PDT
(This is already fixed in the engine (ArrayBuffer::tryCreate copies the payload). Added a regression test that mutates a returned buffer and checks later customSections results are unchanged.)
EWS
Comment 3
2026-08-01 20:09:21 PDT
Committed
318396@main
(4517c96eee86): <
https://commits.webkit.org/318396@main
> Reviewed commits have been landed. Closing PR #69958 and removing active labels.
Radar WebKit Bug Importer
Comment 4
2026-08-01 20:10:13 PDT
<
rdar://problem/183840276
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug