Bug 166462 - WebAssembly: link import calls directly, instead of delaying to Plan linking
Summary: WebAssembly: link import calls directly, instead of delaying to Plan linking
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 165282
Blocks: 161709
  Show dependency treegraph
 
Reported: 2016-12-23 10:13 PST by JF Bastien
Modified: 2020-01-24 09:18 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description JF Bastien 2016-12-23 10:13:44 PST
The WasmB3IRGenerator's addCall doesn't need to generate a patchpoint for imports (toJS and toWasm) because they all get generated before the B3 compilation starts. Plan the goes through m_unlinkedWasmToWasmCalls and links them after all B3 compilation is done, which is extra work we didn't need to do.

This is a slight optimization and requires improving WasmB3IRGenerator, which I'll do later. I'm leaving two FIXMEs for now.