Bug 166447 - WebAssembly: Make spec-tests/f32.wast.js and spec-tests/f64.wast.js pass
Summary: WebAssembly: Make spec-tests/f32.wast.js and spec-tests/f64.wast.js pass
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on: 166446
Blocks:
  Show dependency treegraph
 
Reported: 2016-12-22 16:43 PST by Keith Miller
Modified: 2016-12-22 18:15 PST (History)
5 users (show)

See Also:


Attachments
Patch (6.62 KB, patch)
2016-12-22 18:08 PST, Keith Miller
no flags Details | Formatted Diff | Diff
Patch (10.91 KB, patch)
2016-12-22 18:11 PST, Keith Miller
saam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-12-22 16:43:35 PST
...
Comment 1 Keith Miller 2016-12-22 18:08:04 PST
Created attachment 297696 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2016-12-22 18:09:23 PST
<rdar://problem/29795709>
Comment 3 Radar WebKit Bug Importer 2016-12-22 18:09:23 PST
<rdar://problem/29795708>
Comment 4 WebKit Commit Bot 2016-12-22 18:10:03 PST
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".
Comment 5 Keith Miller 2016-12-22 18:11:19 PST
Created attachment 297697 [details]
Patch
Comment 6 Saam Barati 2016-12-22 18:14:18 PST
Comment on attachment 297696 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297696&action=review

> Source/JavaScriptCore/ChangeLog:12
> +        we use an and and the sign bit gets dropped.

I think you should finish this as:
"sign bit gets dropped if one is 0.0 and the other is -0.0, otherwise, we get the same number back"
or something like that
Comment 7 Keith Miller 2016-12-22 18:15:18 PST
Committed r210127: <http://trac.webkit.org/changeset/210127>