Bug 166446 - Add BitOr for floating points to B3
Summary: Add BitOr for floating points to B3
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks: 166447
  Show dependency tree / graph
 
Reported: 2016-12-22 16:43 PST by Keith Miller
Modified: 2016-12-22 18:02 PST (History)
6 users (show)

See Also:

Attachments
Patch (24.33 KB, patch)
2016-12-22 16:49 PST, Keith Miller 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-12-22 16:43:17 PST 
Add BitOr for floating points to B3
Comment 1 Keith Miller 2016-12-22 16:49:32 PST 
Created attachment 297689 [details]
Patch
Comment 2 Michael Saboff 2016-12-22 16:52:03 PST 
Comment on attachment 297689 [details]
Patch

The macro assembler changes look good to me.
Comment 3 Saam Barati 2016-12-22 16:55:26 PST 
Comment on attachment 297689 [details]
Patch

r=me
Comment 4 Saam Barati 2016-12-22 16:57:26 PST 
You might want to add the necessary code to B3ReduceDoubleToFloat. I think it's a one line change.
Comment 5 Saam Barati 2016-12-22 16:59:18 PST 
(In reply to comment #4)
> You might want to add the necessary code to B3ReduceDoubleToFloat. I think
> it's a one line change.

Ignore me. This comment is wrong.
Comment 6 Keith Miller 2016-12-22 17:20:40 PST 
Committed r210124: <http://trac.webkit.org/changeset/210124>
Comment 7 Radar WebKit Bug Importer 2016-12-22 18:02:58 PST 
<rdar://problem/29795645>