Bug 166032 - REGRESSION: API test failure: WKWebView.LocalStorageClear
Summary: REGRESSION: API test failure: WKWebView.LocalStorageClear
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-19 13:32 PST by Ryan Haddad
Modified: 2016-12-21 17:58 PST (History)
5 users (show)

See Also:

Attachments
proposed fix (2.49 KB, patch)
2016-12-21 15:23 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-12-19 13:32:16 PST 
FAIL WKWebView.LocalStorageClear

/Volumes/Data/slave/sierra-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:84
Value of: [[NSFileManager defaultManager] fileExistsAtPath:dbWALPath]
  Actual: true
Expected: false


/Volumes/Data/slave/sierra-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:85
Value of: [[NSFileManager defaultManager] fileExistsAtPath:trackerPath]
  Actual: true
Expected: false


/Volumes/Data/slave/sierra-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:86
Value of: [[NSFileManager defaultManager] fileExistsAtPath:trackerSHMPath]
  Actual: true
Expected: false


/Volumes/Data/slave/sierra-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:87
Value of: [[NSFileManager defaultManager] fileExistsAtPath:trackerWALPath]
  Actual: true
Expected: false

https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/2323/steps/run-api-tests/logs/stdio
Comment 1 Ryan Haddad 2016-12-19 13:32:53 PST 
Started after the Sierra bots were updated to 10.12.2
Comment 2 Radar WebKit Bug Importer 2016-12-20 12:35:26 PST 
<rdar://problem/29758423>
Comment 3 Brady Eidson 2016-12-20 12:39:08 PST 
Confirmed locally on my 10.12.2 machine (where API tests all passed back on 10.12.1)
Comment 4 Alexey Proskuryakov 2016-12-21 15:23:50 PST 
Created attachment 297626 [details]
proposed fix

Same as Simon's fix in bug 166031.
Comment 5 WebKit Commit Bot 2016-12-21 17:58:07 PST 
Comment on attachment 297626 [details]
proposed fix

Clearing flags on attachment: 297626

Committed r210093: <http://trac.webkit.org/changeset/210093>
Comment 6 WebKit Commit Bot 2016-12-21 17:58:11 PST 
All reviewed patches have been landed.  Closing bug.