Bug 166031 - REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
Summary: REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-19 13:32 PST by Ryan Haddad
Modified: 2016-12-21 15:22 PST (History)
4 users (show)

See Also:


Attachments
Patch (3.17 KB, patch)
2016-12-20 17:17 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-12-19 13:32:14 PST
FAIL WKWebView.EvaluateJavaScriptBlockCrash

/Volumes/Data/slave/sierra-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:53
Value of: error
  Actual: false
Expected: true

https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/2323/steps/run-api-tests/logs/stdio
Comment 1 Ryan Haddad 2016-12-19 13:32:49 PST
Started after the Sierra bots were updated to 10.12.2
Comment 2 Simon Fraser (smfr) 2016-12-20 11:57:13 PST
Who added the test?
Comment 3 Ryan Haddad 2016-12-20 12:06:09 PST
(In reply to comment #2)
> Who added the test?

Blame points to you for adding the file, but the changelog has a lot of OOPS in it: https://trac.webkit.org/changeset/179160
Comment 4 Simon Fraser (smfr) 2016-12-20 12:14:14 PST
Wow, have no memory of that.
Comment 5 Radar WebKit Bug Importer 2016-12-20 12:35:01 PST
<rdar://problem/29758419>
Comment 6 Simon Fraser (smfr) 2016-12-20 16:54:10 PST
This commit is more helpful: https://trac.webkit.org/changeset/179161
Comment 7 Simon Fraser (smfr) 2016-12-20 16:58:56 PST
The test does this:
    // Force the WKWebView to be destroyed to allow evaluateJavaScript's completion handler to be called with an error.
    webView = nullptr;

but it seems like this no longer has the desired result.
Comment 8 Simon Fraser (smfr) 2016-12-20 17:07:05 PST
AppKit changed to start autoreleasing the WKWebView. The test is no longer valid.
Comment 9 Simon Fraser (smfr) 2016-12-20 17:17:38 PST
Created attachment 297571 [details]
Patch
Comment 10 WebKit Commit Bot 2016-12-20 18:18:33 PST
Comment on attachment 297571 [details]
Patch

Clearing flags on attachment: 297571

Committed r210050: <http://trac.webkit.org/changeset/210050>
Comment 11 WebKit Commit Bot 2016-12-20 18:18:37 PST
All reviewed patches have been landed.  Closing bug.