FAIL WKWebView.EvaluateJavaScriptBlockCrash /Volumes/Data/slave/sierra-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:53 Value of: error Actual: false Expected: true https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/2323/steps/run-api-tests/logs/stdio
Started after the Sierra bots were updated to 10.12.2
Who added the test?
(In reply to comment #2) > Who added the test? Blame points to you for adding the file, but the changelog has a lot of OOPS in it: https://trac.webkit.org/changeset/179160
Wow, have no memory of that.
<rdar://problem/29758419>
This commit is more helpful: https://trac.webkit.org/changeset/179161
The test does this: // Force the WKWebView to be destroyed to allow evaluateJavaScript's completion handler to be called with an error. webView = nullptr; but it seems like this no longer has the desired result.
AppKit changed to start autoreleasing the WKWebView. The test is no longer valid.
Created attachment 297571 [details] Patch
Comment on attachment 297571 [details] Patch Clearing flags on attachment: 297571 Committed r210050: <http://trac.webkit.org/changeset/210050>
All reviewed patches have been landed. Closing bug.