RESOLVED FIXED 166031
REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash 
https://bugs.webkit.org/show_bug.cgi?id=166031
Summary REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
Ryan Haddad
Reported 2016-12-19 13:32:14 PST
FAIL WKWebView.EvaluateJavaScriptBlockCrash /Volumes/Data/slave/sierra-release/build/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:53 Value of: error Actual: false Expected: true https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/2323/steps/run-api-tests/logs/stdio
Attachments
Patch (3.17 KB, patch)
2016-12-20 17:17 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2016-12-19 13:32:49 PST
Started after the Sierra bots were updated to 10.12.2
Simon Fraser (smfr)
Comment 2 2016-12-20 11:57:13 PST
Who added the test?
Ryan Haddad
Comment 3 2016-12-20 12:06:09 PST
(In reply to comment #2) > Who added the test? Blame points to you for adding the file, but the changelog has a lot of OOPS in it: https://trac.webkit.org/changeset/179160
Simon Fraser (smfr)
Comment 4 2016-12-20 12:14:14 PST
Wow, have no memory of that.
Radar WebKit Bug Importer
Comment 5 2016-12-20 12:35:01 PST
<rdar://problem/29758419>
Simon Fraser (smfr)
Comment 6 2016-12-20 16:54:10 PST
This commit is more helpful: https://trac.webkit.org/changeset/179161
Simon Fraser (smfr)
Comment 7 2016-12-20 16:58:56 PST
The test does this: // Force the WKWebView to be destroyed to allow evaluateJavaScript's completion handler to be called with an error. webView = nullptr; but it seems like this no longer has the desired result.
Simon Fraser (smfr)
Comment 8 2016-12-20 17:07:05 PST
AppKit changed to start autoreleasing the WKWebView. The test is no longer valid.
Simon Fraser (smfr)
Comment 9 2016-12-20 17:17:38 PST
Created attachment 297571 [details] Patch
WebKit Commit Bot
Comment 10 2016-12-20 18:18:33 PST
Comment on attachment 297571 [details] Patch Clearing flags on attachment: 297571 Committed r210050: <http://trac.webkit.org/changeset/210050>
WebKit Commit Bot
Comment 11 2016-12-20 18:18:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.