Bug 165969 - CellState should have members with accurate names
Summary: CellState should have members with accurate names
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 165909
  Show dependency tree / graph
 
Reported: 2016-12-16 14:02 PST by Filip Pizlo
Modified: 2016-12-16 18:42 PST (History)
5 users (show)

See Also:

Attachments
the patch (8.51 KB, patch)
2016-12-16 14:07 PST, Filip Pizlo 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-12-16 14:02:16 PST 
I keep having to rename members in CellState because understanding their meaning is so hard.
Comment 1 Filip Pizlo 2016-12-16 14:07:55 PST 
Created attachment 297354 [details]
the patch
Comment 2 Mark Lam 2016-12-16 14:13:23 PST 
Comment on attachment 297354 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297354&action=review

r=me with typo fix.

> Source/JavaScriptCore/heap/CellState.h:34
> +    // is a full collection and it's actually a while object (you'd know because its mark bit

/while/white/?
Comment 3 Filip Pizlo 2016-12-16 18:40:11 PST 
(In reply to comment #2)
> Comment on attachment 297354 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=297354&action=review
> 
> r=me with typo fix.
> 
> > Source/JavaScriptCore/heap/CellState.h:34
> > +    // is a full collection and it's actually a while object (you'd know because its mark bit
> 
> /while/white/?

Yup, fixed!
Comment 4 Filip Pizlo 2016-12-16 18:42:04 PST 
Landed in https://trac.webkit.org/changeset/209954