Bug 165888 – WebAssembly: implement init_expr for Element

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

...

[Radar WebKit Bug Importer]

<rdar://problem/29760199>

[Saam Barati]

Created attachment 303375 [details]
WIP

Needs a test. Also contains part of another patch inside of it.

[Saam Barati]

*** Bug 169183 has been marked as a duplicate of this bug. ***

[Saam Barati]

Created attachment 303460 [details]
patch

[Keith Miller]

Comment on attachment 303460 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303460&action=review

r=me with a comment.

> Source/JavaScriptCore/wasm/WasmModuleParser.cpp:442
> +        WASM_PARSER_FAIL_IF(initExprType != I32, elementNum, "th Element init_expr must produce an i32");

typo: the*

I think I would say "Element init_expr must return an i32" though.

[Saam Barati]

landed in:
https://trac.webkit.org/changeset/213465

[Carlos Alberto Lopez Perez]

(In reply to comment #6)
> landed in:
> https://trac.webkit.org/changeset/213465

This has caused the test wasm.yaml/wasm/js-api/element.js to fail:


https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20JSC%20%28Tests%29/builds/12917/steps/jscore-test/logs/stdio

Running wasm.yaml/wasm/js-api/globals-export.js.default-wasm
wasm.yaml/wasm/js-api/element.js.default-wasm: Exception: Error: Expected to throw a CompileError with message "WebAssembly.Module doesn't parse at byte 58 / 72: 0th Element init_expr must produce an i32", got Error with message "WebAssembly.Module doesn't parse at byte 58 / 72: Element init_expr must produce an i32 (evaluating 'new WebAssembly.Module(bin)')"
wasm.yaml/wasm/js-api/element.js.default-wasm: _fail@/Volumes/Data/slave/elcapitan-release-tests-jsc/build/WebKitBuild/Release/jsc-stress-results/.tests/wasm.yaml/wasm/assert.js:27:20
wasm.yaml/wasm/js-api/element.js.default-wasm: _throws@/Volumes/Data/slave/elcapitan-release-tests-jsc/build/WebKitBuild/Release/jsc-stress-results/.tests/wasm.yaml/wasm/assert.js:128:14
wasm.yaml/wasm/js-api/element.js.default-wasm: module code@/Volumes/Data/slave/elcapitan-release-tests-jsc/build/WebKitBuild/Release/jsc-stress-results/.tests/wasm.yaml/wasm/js-api/element.js:218:18
wasm.yaml/wasm/js-api/element.js.default-wasm: evaluate@[native code]
wasm.yaml/wasm/js-api/element.js.default-wasm: moduleEvaluation@[native code]
wasm.yaml/wasm/js-api/element.js.default-wasm: [native code]
wasm.yaml/wasm/js-api/element.js.default-wasm: promiseReactionJob@[native code]
Running wasm.yaml/wasm/js-api/globals-import.js.default-wasm
wasm.yaml/wasm/js-api/element.js.default-wasm: ERROR: Unexpected exit code: 3

[Saam Barati]

Will fix now.

[Saam Barati]

Landed fix in:
https://trac.webkit.org/changeset/213484