Bug 165750 - [css-grid] Add some test cases that were removed in r209562
Summary: [css-grid] Add some test cases that were removed in r209562
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-12 01:39 PST by Manuel Rego Casasnovas
Modified: 2016-12-12 12:49 PST (History)
5 users (show)

See Also:

Attachments
Patch (6.78 KB, patch)
2016-12-12 01:40 PST, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Patch (10.19 KB, patch)
2016-12-12 01:47 PST, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2016-12-12 01:39:48 PST 
[css-grid] Add some test cases that were removed in r209562
Comment 1 Manuel Rego Casasnovas 2016-12-12 01:40:15 PST 
Created attachment 296899 [details]
Patch
Comment 2 Manuel Rego Casasnovas 2016-12-12 01:47:40 PST 
Created attachment 296900 [details]
Patch
Comment 3 Manuel Rego Casasnovas 2016-12-12 01:49:30 PST 
These tests cases were removed in bug #165623.
Comment 4 Sergio Villar Senin 2016-12-12 06:40:16 PST 
Comment on attachment 296900 [details]
Patch

I guess you have verified that 0fr does not trigger a division by zero or any other error like that in the renderer.
Comment 5 Manuel Rego Casasnovas 2016-12-12 12:24:32 PST 
(In reply to comment #4)
> Comment on attachment 296900 [details]
> Patch
> 
> I guess you have verified that 0fr does not trigger a division by zero or
> any other error like that in the renderer.

Yes the patch related to that is quite old r190308 (see bug #148944),
but it seems the changes on the parser were not done at that time.

In any case this is just modifying the tests.
Comment 6 WebKit Commit Bot 2016-12-12 12:49:44 PST 
Comment on attachment 296900 [details]
Patch

Clearing flags on attachment: 296900

Committed r209721: <http://trac.webkit.org/changeset/209721>
Comment 7 WebKit Commit Bot 2016-12-12 12:49:49 PST 
All reviewed patches have been landed.  Closing bug.