RESOLVED FIXED 165623
[CSS Parser] Unskip grid tests 
https://bugs.webkit.org/show_bug.cgi?id=165623
Summary [CSS Parser] Unskip grid tests
Dave Hyatt
Reported 2016-12-08 13:16:39 PST
[CSS Parser] Unskip grid tests
Attachments
Patch (10.44 KB, patch)
2016-12-08 13:18 PST, Dave Hyatt 		zalan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2016-12-08 13:18:15 PST
Created attachment 296557 [details] Patch
Dave Hyatt
Comment 2 2016-12-08 13:26:37 PST
Fixed in r209562.
Manuel Rego Casasnovas
Comment 3 2016-12-12 01:48:58 PST
Comment on attachment 296557 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296557&action=review This removed some valid test cases, I'm adding them back in bug #165750. > LayoutTests/ChangeLog:3 > + [CSS Parser] Unskip grid tests Sorry but this patch is doing something else thank unskip some tests. It'd be nice to be more specific on the ChangeLog. > LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set.html:-270 > - testGridDefinitionsSetJSValues("[foo1 bar1] 'a' 50px [foo2 bar2] [foo3 bar3] 'b' 50px [foo4 bar4] / 100px", "100px", "[foo1 bar1] 50px [foo2 bar2 foo3 bar3] 50px [foo4 bar4]", "\"a\" \"b\""); We shouldn't remove this test case, as the only "issue" is that the specified value is kept now. Just passing the proper extra arguments fix it. > LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js:-96 > -testGridTemplatesSetBadJSValues("0fr", "1r"); It's fine "0fr" is valid now, we should probably move this to the previous part of the test where we check right values. > LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js:-98 > -testGridTemplatesSetBadJSValues(".0000fr", "13 fr"); It'd be good to keep checking that a space is not allowed.
Note You need to log in before you can comment on or make changes to this bug.