Bug 165714 - WebAssembly: test throwing out of the start function
Summary: WebAssembly: test throwing out of the start function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: JF Bastien
URL:
Keywords: InRadar
Depends on: 165150
Blocks: 161709
  Show dependency tree / graph
 
Reported: 2016-12-09 19:09 PST by JF Bastien
Modified: 2017-07-26 16:29 PDT (History)
6 users (show)

See Also:

Attachments
patch (4.30 KB, patch)
2017-07-26 10:10 PDT, JF Bastien 		keith_miller: review+
keith_miller: commit-queue-
Details | Formatted Diff | Diff
patch (5.78 KB, patch)
2017-07-26 14:47 PDT, JF Bastien 		no flags Details | Formatted Diff | Diff
patch (9.31 KB, patch)
2017-07-26 14:55 PDT, JF Bastien 		buildbot: commit-queue-
Details | Formatted Diff | Diff
patch (9.31 KB, patch)
2017-07-26 15:51 PDT, JF Bastien 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description JF Bastien 2016-12-09 19:09:44 PST 
.
Comment 1 Radar WebKit Bug Importer 2016-12-20 14:26:10 PST 
<rdar://problem/29760251>
Comment 2 JF Bastien 2017-07-26 10:10:51 PDT 
Created attachment 316452 [details]
patch
Comment 3 Keith Miller 2017-07-26 10:13:12 PDT 
Comment on attachment 316452 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316452&action=review

r=me with comment.

> JSTests/wasm/function-tests/trap-from-start.js:48
> +    assert.throws(() => new WebAssembly.Instance(module, imp), WebAssembly.RuntimeError, `Out of bounds memory access`);

Can we also get a version of this with instantiate?
Comment 4 JF Bastien 2017-07-26 14:47:58 PDT 
Created attachment 316484 [details]
patch

Add async test.
Comment 5 JF Bastien 2017-07-26 14:55:33 PDT 
Created attachment 316486 [details]
patch

Forgot a file.
Comment 6 Build Bot 2017-07-26 15:39:45 PDT 
Comment on attachment 316486 [details]
patch

Attachment 316486 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/4192723

New failing tests:
wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-no-call-ic
wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-eager-jettison
wasm.yaml/wasm/function-tests/trap-from-start.js.default-wasm
wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-no-tls-context
wasm.yaml/wasm/function-tests/trap-from-start.js.wasm-no-cjit-yes-tls-context
Comment 7 JF Bastien 2017-07-26 15:51:18 PDT 
Created attachment 316492 [details]
patch

Add back inadvertently removed `new`.
Comment 8 WebKit Commit Bot 2017-07-26 16:29:28 PDT 
Comment on attachment 316492 [details]
patch

Clearing flags on attachment: 316492

Committed r219969: <http://trac.webkit.org/changeset/219969>
Comment 9 WebKit Commit Bot 2017-07-26 16:29:29 PDT 
All reviewed patches have been landed.  Closing bug.