Bug 165641 - [WebIDL] Merge JSDictionary into Dictionary, and remove unused bits
Summary: [WebIDL] Merge JSDictionary into Dictionary, and remove unused bits
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
: 156853 (view as bug list)
Depends on: 165625
Blocks:
  Show dependency treegraph
 
Reported: 2016-12-08 18:10 PST by Sam Weinig
Modified: 2016-12-10 14:14 PST (History)
3 users (show)

See Also:


Attachments
Patch (54.57 KB, patch)
2016-12-08 18:18 PST, Sam Weinig
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (1.13 MB, application/zip)
2016-12-08 19:02 PST, Build Bot
no flags Details
Archive of layout-test-results from ews113 for mac-yosemite (1.79 MB, application/zip)
2016-12-08 19:26 PST, Build Bot
no flags Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.57 MB, application/zip)
2016-12-08 20:21 PST, Build Bot
no flags Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (deleted)
2016-12-08 20:42 PST, Build Bot
no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (deleted)
2016-12-08 22:42 PST, Build Bot
no flags Details
Patch (47.49 KB, patch)
2016-12-09 22:27 PST, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (47.49 KB, patch)
2016-12-10 11:38 PST, Sam Weinig
mitz: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (1.27 MB, application/zip)
2016-12-10 13:13 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2016-12-08 18:10:49 PST
[WebIDL] Merge JSDictionary into Dictionary, and remove unused bits
Comment 1 Sam Weinig 2016-12-08 18:18:06 PST
Created attachment 296608 [details]
Patch
Comment 2 Build Bot 2016-12-08 19:02:47 PST
Comment on attachment 296608 [details]
Patch

Attachment 296608 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2658822

Number of test failures exceeded the failure limit.
Comment 3 Build Bot 2016-12-08 19:02:50 PST
Created attachment 296613 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-12-08 19:26:25 PST
Comment on attachment 296608 [details]
Patch

Attachment 296608 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2659185

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2016-12-08 19:26:27 PST
Created attachment 296620 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-12-08 20:21:46 PST
Comment on attachment 296608 [details]
Patch

Attachment 296608 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2660219

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2016-12-08 20:21:48 PST
Created attachment 296629 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-12-08 20:42:26 PST
Comment on attachment 296608 [details]
Patch

Attachment 296608 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2659838

Number of test failures exceeded the failure limit.
Comment 9 Build Bot 2016-12-08 20:42:32 PST
Created attachment 296633 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 10 Build Bot 2016-12-08 22:42:12 PST
Comment on attachment 296608 [details]
Patch

Attachment 296608 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2661932

Number of test failures exceeded the failure limit.
Comment 11 Build Bot 2016-12-08 22:42:18 PST
Created attachment 296642 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 12 Darin Adler 2016-12-09 21:27:29 PST
*** Bug 156853 has been marked as a duplicate of this bug. ***
Comment 13 Sam Weinig 2016-12-09 22:27:38 PST
Created attachment 296780 [details]
Patch
Comment 14 Sam Weinig 2016-12-10 11:38:52 PST
Created attachment 296812 [details]
Patch
Comment 15 mitz 2016-12-10 13:05:19 PST
Comment on attachment 296812 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296812&action=review

> Source/WebCore/bindings/js/Dictionary.cpp:47
> +Dictionary::Dictionary(JSC::ExecState* state, JSC::JSValue value)

No need for JSC:: here.

> Source/WebCore/bindings/js/Dictionary.cpp:85
> +// MARK: -
> +// MARK: Value convversions

Extra “v” in “convversions”. Can collapse these into // MARK: - Value conversions
Comment 16 Build Bot 2016-12-10 13:13:46 PST
Comment on attachment 296812 [details]
Patch

Attachment 296812 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2690730

New failing tests:
transitions/default-timing-function.html
Comment 17 Build Bot 2016-12-10 13:13:48 PST
Created attachment 296818 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 18 Sam Weinig 2016-12-10 14:14:28 PST
Committed r209674: <http://trac.webkit.org/changeset/209674>