[WebIDL] Remove custom bindings for Geolcation
Created attachment 296561 [details]
Committed r209574: <http://trac.webkit.org/changeset/209574>
(In reply to comment #2)
> Committed r209574: <http://trac.webkit.org/changeset/209574>
It broke the WinCairo build, see build.webkit.org for details.
Reverted r209574 for reason:
This change broke the Windows build.
Committed r209612: <http://trac.webkit.org/changeset/209612>
(In reply to comment #4)
> Reverted r209574 for reason:
> This change broke the Windows build.
> Committed r209612: <http://trac.webkit.org/changeset/209612>
Link to failure:
Any windows folks understand the issue?
I confirmed inlining Geolocation::frame in the header fixes the linker issue. Not sure exactly why, but I don't see any reason to look into this further. I will look into it further if we run into more such problems. Remember to remove WEBCORE_EXPORT, include Document.h, and remove the definition in the .cpp
Created attachment 296802 [details]
Comment on attachment 296802 [details]
Attachment 296802 [details] did not pass mac-wk2-ews (mac-wk2):
New failing tests:
Created attachment 296807 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Committed r209669: <http://trac.webkit.org/changeset/209669>