Bug 165625 - [WebIDL] Remove custom bindings for Geolocation
Summary: [WebIDL] Remove custom bindings for Geolocation
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
Depends on:
Blocks: 165641
  Show dependency treegraph
Reported: 2016-12-08 13:33 PST by Sam Weinig
Modified: 2016-12-10 11:36 PST (History)
7 users (show)

See Also:

Patch (56.44 KB, patch)
2016-12-08 13:43 PST, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (57.23 KB, patch)
2016-12-10 08:07 PST, Sam Weinig
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.49 MB, application/zip)
2016-12-10 10:32 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2016-12-08 13:33:36 PST
[WebIDL] Remove custom bindings for Geolcation
Comment 1 Sam Weinig 2016-12-08 13:43:12 PST
Created attachment 296561 [details]
Comment 2 Sam Weinig 2016-12-08 14:53:06 PST
Committed r209574: <http://trac.webkit.org/changeset/209574>
Comment 3 Csaba Osztrogonác 2016-12-09 04:17:42 PST
(In reply to comment #2)
> Committed r209574: <http://trac.webkit.org/changeset/209574>

It broke the WinCairo build, see build.webkit.org for details.
Comment 4 Ryan Haddad 2016-12-09 10:13:03 PST
Reverted r209574 for reason:

This change broke the Windows build.

Committed r209612: <http://trac.webkit.org/changeset/209612>
Comment 5 Ryan Haddad 2016-12-09 10:13:24 PST
(In reply to comment #4)
> Reverted r209574 for reason:
> This change broke the Windows build.
> Committed r209612: <http://trac.webkit.org/changeset/209612>

Link to failure:

Comment 6 Sam Weinig 2016-12-09 10:46:17 PST
Any windows folks understand the issue?
Comment 7 Alex Christensen 2016-12-09 15:19:56 PST
I confirmed inlining Geolocation::frame in the header fixes the linker issue.  Not sure exactly why, but I don't see any reason to look into this further.  I will look into it further if we run into more such problems.  Remember to remove WEBCORE_EXPORT, include Document.h, and remove the definition in the .cpp
Comment 8 Sam Weinig 2016-12-10 08:07:51 PST
Created attachment 296802 [details]
Comment 9 Build Bot 2016-12-10 10:32:04 PST
Comment on attachment 296802 [details]

Attachment 296802 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2689733

New failing tests:
Comment 10 Build Bot 2016-12-10 10:32:07 PST
Created attachment 296807 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 11 Sam Weinig 2016-12-10 11:36:38 PST
Committed r209669: <http://trac.webkit.org/changeset/209669>