Bug #164724 seems to cause build issues which I haven't tracked down yet. WasmOps.h can't be found: ./Source/JavaScriptCore/wasm/WasmFormat.h:34:10: fatal error: 'WasmOps.h' file not found It's weird since the file is auto-generated and has been for a while. #164724 merely includes it in WasmFormat.h. I have to run out now, so I'll revert #164724 and investigate separately.
Created attachment 295951 [details] patch I had to merge around Keith's FP op patch. My local build seems to work. I'll investigate the failure later today, gotta run now.
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".
Comment on attachment 295951 [details] patch cq+ since the public build isn't broken, but some internal one is.
Created attachment 295952 [details] patch Update "reviewed by".
(In reply to comment #4) > Created attachment 295952 [details] > patch > > Update "reviewed by". You don't need a review to roll out a broken patch (suspected or otherwise).
Comment on attachment 295952 [details] patch Rejecting attachment 295952 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 295952, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/JSTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/2607884
Comment on attachment 295952 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=295952&action=review > JSTests/ChangeLog:6 > + Reviewed by NOBODY (fix build break). Change this to "Not reviewed" and you should be fine. Or I can review it.
Created attachment 295953 [details] patch "unreviewed"
Comment on attachment 295953 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=295953&action=review > JSTests/ChangeLog:-70 > - WebAssembly: update binary format to 0xD version > - https://bugs.webkit.org/show_bug.cgi?id=164724 > - > - Reviewed by Saam Barati. > - > - As described in the following PR: https://github.com/WebAssembly/design/pull/836 > - > - * wasm/Builder.js: > - (const._normalizeFunctionSignature): > - * wasm/Builder_WebAssemblyBinary.js: > - (const.emitters.Type): > - (const.emitters.Code): > - * wasm/LowLevelBinary.js: > - (export.default.LowLevelBinary.prototype.block_type): > - (export.default.LowLevelBinary.prototype.inline_signature_type): Deleted. > - * wasm/WASM.js: > - * wasm/js-api/test_basic_api.js: > - * wasm/self-test/test_BuilderWebAssembly.js: > - (EmptyModule): > - (CustomSection): > - * wasm/self-test/test_WASM.js: > - * wasm/wasm.json: > - > -2016-11-30 JF Bastien <jfbastien@apple.com> > - I wouldn't delete this, we keep the changelog as a historical record of everything that's been committed in the past.
Comment on attachment 295953 [details] patch Clearing flags on attachment: 295953 Committed r209242: <http://trac.webkit.org/changeset/209242>
All reviewed patches have been landed. Closing bug.
> I wouldn't delete this, we keep the changelog as a historical record of > everything that's been committed in the past. Ugh my bad, I didn't think about that bit and assumed the git hooks would take care of it. I can put it back when I un-revert the revert.