Bug 165196 - Some scroll snapping tests are still flaky
Summary: Some scroll snapping tests are still flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
: 172148 209293 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-11-30 08:02 PST by Wenson Hsieh
Modified: 2020-03-20 09:23 PDT (History)
11 users (show)

See Also:

Attachments
Patch (4.15 MB, patch)
2016-11-30 10:13 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Another attempt to observe flaky failures. (4.15 MB, patch)
2016-11-30 16:49 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (6.55 KB, patch)
2020-03-19 21:22 PDT, Simon Fraser (smfr) 		wenson_hsieh: review+
Details | Formatted Diff | Diff
Patch (6.58 KB, patch)
2020-03-19 21:36 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2016-11-30 08:02:41 PST 
So far, this includes three tests:
- tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe.html
- tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-slow-horizontal.html
- tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-slow-vertical.html
Comment 1 Wenson Hsieh 2016-11-30 10:13:03 PST 
Created attachment 295729 [details]
Patch
Comment 2 Wenson Hsieh 2016-11-30 16:49:42 PST 
Created attachment 295789 [details]
Another attempt to observe flaky failures.
Comment 3 Wenson Hsieh 2017-07-24 09:44:01 PDT 
*** Bug 172148 has been marked as a duplicate of this bug. ***
Comment 4 Simon Fraser (smfr) 2020-03-19 18:46:19 PDT 
scroll-snap-mandatory-mainframe-slow-vertical.html is still flakey.

The scroll snap timer fires on the scrolling thread with the right offset, but the main thread hasn't caught up yet by the time we remove the "scroll snap" reason on the wheel event monitor.
Comment 5 Simon Fraser (smfr) 2020-03-19 21:22:00 PDT 
Created attachment 394064 [details]
Patch
Comment 6 Wenson Hsieh 2020-03-19 21:29:05 PDT 
Comment on attachment 394064 [details]
Patch

r=me with the UNUSED_PARAM to fix the iOS build.
Comment 7 Simon Fraser (smfr) 2020-03-19 21:36:42 PDT 
Created attachment 394066 [details]
Patch
Comment 8 EWS 2020-03-19 23:03:39 PDT 
Committed r258753: <https://trac.webkit.org/changeset/258753>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 394066 [details].
Comment 9 Radar WebKit Bug Importer 2020-03-19 23:04:18 PDT 
<rdar://problem/60671382>
Comment 10 Simon Fraser (smfr) 2020-03-20 09:23:58 PDT 
*** Bug 209293 has been marked as a duplicate of this bug. ***