Bug 148408 - Some scroll snap overflow tests are flaky
Summary: Some scroll snap overflow tests are flaky
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-24 17:28 PDT by Alexey Proskuryakov
Modified: 2016-12-01 10:36 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-08-24 17:28:26 PDT
Some scroll snap tests have become flaky when asynchronous. This is reproducible locally when repeating them many times, e.g. "--repeat 500 -f".

tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-borders.html
tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow.html
tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-rotated.html
tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-padding.html
Comment 1 Alexey Proskuryakov 2015-08-24 17:35:27 PDT
Also tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe.html

Marked as flaky in r188899.
Comment 2 Alexey Proskuryakov 2015-08-27 10:18:03 PDT
There is a clear opportunity for a race between the end of regular scroll and the beginning of momentum scroll.

Some potential approaches:

- tell eventSender.callAfterScrollingCompletes whether it needs to wait for momentum scroll;

- this could be automagic, because all scrolls are started via eventSender functions, and we do post the momentum scrolling events before calling eventSender.callAfterScrollingCompletes;

- or it may be possible to have an eventSender function that both finishes regular scroll and starts a momentum one, or some other higher level description of a scroll that we'd use with eventSender. That way, we would keep the knowledge that there is a momentum scroll coming for longer.