WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
165122
[iOS] Tapping on an HTML validation bubble should dismiss it
https://bugs.webkit.org/show_bug.cgi?id=165122
Summary
[iOS] Tapping on an HTML validation bubble should dismiss it
Chris Dumez
Reported
2016-11-28 16:07:28 PST
Tapping on an HTML validation bubble should dismiss it. It currently does nothing.
Attachments
WIP Patch
(3.12 KB, patch)
2016-11-29 15:35 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(4.26 KB, patch)
2016-11-30 12:20 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(4.10 KB, patch)
2016-11-30 13:52 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(4.20 KB, patch)
2016-12-01 14:01 PST
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2016-11-29 15:35:05 PST
Created
attachment 295656
[details]
WIP Patch
Chris Dumez
Comment 2
2016-11-29 15:37:08 PST
<
rdar://problem/29429372
>
Chris Dumez
Comment 3
2016-11-30 12:20:55 PST
Created
attachment 295741
[details]
Patch
Tim Horton
Comment 4
2016-11-30 13:06:00 PST
Comment on
attachment 295741
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=295741&action=review
> Source/WebCore/platform/ios/ValidationBubbleIOS.mm:52 > +- (WebValidationBubbleTapRecognizer *)initWithPopoverController:(UIViewController*)popoverController withPopoverView:(UIView *)popoverView
UIViewController star's on the wrong side. Also, do you really need to pass both? isn't popoverController.view popoverView?
Chris Dumez
Comment 5
2016-11-30 13:10:43 PST
(In reply to
comment #4
)
> Comment on
attachment 295741
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=295741&action=review
> > > Source/WebCore/platform/ios/ValidationBubbleIOS.mm:52 > > +- (WebValidationBubbleTapRecognizer *)initWithPopoverController:(UIViewController*)popoverController withPopoverView:(UIView *)popoverView > > UIViewController star's on the wrong side. Also, do you really need to pass > both? isn't popoverController.view popoverView?
Good point. I'll fix.
Chris Dumez
Comment 6
2016-11-30 13:52:16 PST
Created
attachment 295761
[details]
Patch
Chris Dumez
Comment 7
2016-11-30 13:52:39 PST
(In reply to
comment #5
)
> (In reply to
comment #4
) > > Comment on
attachment 295741
[details]
> > Patch > > > > View in context: > >
https://bugs.webkit.org/attachment.cgi?id=295741&action=review
> > > > > Source/WebCore/platform/ios/ValidationBubbleIOS.mm:52 > > > +- (WebValidationBubbleTapRecognizer *)initWithPopoverController:(UIViewController*)popoverController withPopoverView:(UIView *)popoverView > > > > UIViewController star's on the wrong side. Also, do you really need to pass > > both? isn't popoverController.view popoverView? > > Good point. I'll fix.
Fixed.
Simon Fraser (smfr)
Comment 8
2016-11-30 13:58:46 PST
Comment on
attachment 295761
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=295761&action=review
> Source/WebCore/platform/ios/ValidationBubbleIOS.mm:58 > + _tapGestureRecognizer = adoptNS([[getUITapGestureRecognizerClass() alloc] initWithTarget:self action:@selector(dismissPopover)]);
Are you sure this doesn't create a ref cycle?
Chris Dumez
Comment 9
2016-11-30 14:32:06 PST
Comment on
attachment 295761
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=295761&action=review
>> Source/WebCore/platform/ios/ValidationBubbleIOS.mm:58 >> + _tapGestureRecognizer = adoptNS([[getUITapGestureRecognizerClass() alloc] initWithTarget:self action:@selector(dismissPopover)]); > > Are you sure this doesn't create a ref cycle?
I see WebValidationBubbleTapRecognizer's dealloc getting called so it seems fine.
Chris Dumez
Comment 10
2016-12-01 14:01:28 PST
Created
attachment 295892
[details]
Patch
WebKit Commit Bot
Comment 11
2016-12-02 12:05:42 PST
Comment on
attachment 295892
[details]
Patch Clearing flags on attachment: 295892 Committed
r209253
: <
http://trac.webkit.org/changeset/209253
>
WebKit Commit Bot
Comment 12
2016-12-02 12:05:46 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug