Bug 165046 - Fix exception scope verification failures in runtime/Operations.cpp/h.
Summary: Fix exception scope verification failures in runtime/Operations.cpp/h.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 162351 165035
  Show dependency treegraph
 
Reported: 2016-11-23 09:24 PST by Mark Lam
Modified: 2016-11-28 15:24 PST (History)
7 users (show)

See Also:


Attachments
proposed patch. (6.45 KB, patch)
2016-11-23 09:34 PST, Mark Lam
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-11-23 09:24:04 PST
Patch coming.
Comment 1 Mark Lam 2016-11-23 09:34:41 PST
Created attachment 295370 [details]
proposed patch.
Comment 2 Saam Barati 2016-11-28 14:15:53 PST
Comment on attachment 295370 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=295370&action=review

> Source/JavaScriptCore/runtime/Operations.cpp:54
> +        auto p2String = p2.toString(callFrame);

I think it's helpful to have types here.

> Source/JavaScriptCore/runtime/Operations.cpp:61
> +        auto p1String = p1.toString(callFrame);

ditto
Comment 3 Mark Lam 2016-11-28 15:20:37 PST
Comment on attachment 295370 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=295370&action=review

>> Source/JavaScriptCore/runtime/Operations.cpp:54
>> +        auto p2String = p2.toString(callFrame);
> 
> I think it's helpful to have types here.

Fixed.

>> Source/JavaScriptCore/runtime/Operations.cpp:61
>> +        auto p1String = p1.toString(callFrame);
> 
> ditto

Fixed.
Comment 4 Mark Lam 2016-11-28 15:24:47 PST
Thanks for the review.  Landed in r209030: <http://trac.webkit.org/r209030>.