Patch coming.
Created attachment 295341 [details] proposed patch.
Comment on attachment 295341 [details] proposed patch. Attachment 295341 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2557722 New failing tests: sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.2_The_Greater_than_Operator/S11.8.2_A2.3_T1.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.4_The_Grater_than_or_equal_Operator/S11.8.4_A2.3_T1.html js/dom/exception-sequencing-binops2.html http/tests/plugins/cross-frame-object-access.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.3_The_Less_than_or_equal_Operator/S11.8.3_A2.3_T1.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.1_The_Less_than_Operator/S11.8.1_A2.3_T1.html
Created attachment 295343 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 295341 [details] proposed patch. Attachment 295341 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2557726 New failing tests: sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.2_The_Greater_than_Operator/S11.8.2_A2.3_T1.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.4_The_Grater_than_or_equal_Operator/S11.8.4_A2.3_T1.html js/dom/exception-sequencing-binops2.html http/tests/plugins/cross-frame-object-access.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.3_The_Less_than_or_equal_Operator/S11.8.3_A2.3_T1.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.1_The_Less_than_Operator/S11.8.1_A2.3_T1.html
Created attachment 295344 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 295341 [details] proposed patch. Attachment 295341 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2557729 New failing tests: sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.2_The_Greater_than_Operator/S11.8.2_A2.3_T1.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.4_The_Grater_than_or_equal_Operator/S11.8.4_A2.3_T1.html js/array-proto-func-property-getter-except.html js/dom/exception-sequencing-binops2.html http/tests/plugins/cross-frame-object-access.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.3_The_Less_than_or_equal_Operator/S11.8.3_A2.3_T1.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.1_The_Less_than_Operator/S11.8.1_A2.3_T1.html
Created attachment 295345 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 295341 [details] proposed patch. Attachment 295341 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2557736 New failing tests: js/dom/exception-sequencing-binops2.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.4_The_Grater_than_or_equal_Operator/S11.8.4_A2.3_T1.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.1_The_Less_than_Operator/S11.8.1_A2.3_T1.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.3_The_Less_than_or_equal_Operator/S11.8.3_A2.3_T1.html sputnik/Conformance/11_Expressions/11.8_Relational_Operators/11.8.2_The_Greater_than_Operator/S11.8.2_A2.3_T1.html
Created attachment 295346 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 295341 [details] proposed patch. Taking out of review while I investigate failures
The reason for the failures is because this patch relies on fixes from 2 other patches: 1. Fix exception scope verification failures in ArrayConstructor.cpp and ArrayPrototype.cpp https://bugs.webkit.org/show_bug.cgi?id=164972 2. Fix exception scope verification failures in runtime/Operations.cpp/h. https://bugs.webkit.org/show_bug.cgi?id=165046 Let's hold off on this patch until those others have landed.
Created attachment 295546 [details] proposed patch. The relevant other patches have landed. Let's rebase and test this on the EWS again.
Comment on attachment 295546 [details] proposed patch. Attachment 295546 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2585630 New failing tests: http/tests/plugins/cross-frame-object-access.html
Created attachment 295558 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 295546 [details] proposed patch. Attachment 295546 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2585741 New failing tests: http/tests/plugins/cross-frame-object-access.html
Created attachment 295559 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 295546 [details] proposed patch. Attachment 295546 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2586144 New failing tests: http/tests/plugins/cross-frame-object-access.html
Created attachment 295571 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5
(In reply to comment #17) > New failing tests: > http/tests/plugins/cross-frame-object-access.html The reason for this failure is that there's a missing exception check in NPJSObject.cpp. Fixing that missing exception check is easy. However, the test now fails because the plugin is now losing some XSS ability. I'm not sure if it is supposed to have that ability to begin with (though the test claims that it should). This will take a little more investigation.
This is now supplanted by https://bugs.webkit.org/show_bug.cgi?id=176662. Closing as a dupe. *** This bug has been marked as a duplicate of bug 176662 ***