Bug 164938 - Remove the deprecated WebKitSubtleCrypto interface
Summary: Remove the deprecated WebKitSubtleCrypto interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on: 164943 164939 169806
Blocks: 173325
  Show dependency tree / graph
 
Reported: 2016-11-18 11:31 PST by Jiewen Tan
Modified: 2017-08-18 16:25 PDT (History)
7 users (show)

See Also:

Attachments
Patch (499.67 KB, patch)
2017-08-18 14:24 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (504.18 KB, patch)
2017-08-18 14:58 PDT, Sam Weinig 		cdumez: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2016-11-18 11:31:21 PST 
This is an umbrella bug for deprecating WebKitSubtleCrypto.
Comment 1 Radar WebKit Bug Importer 2017-01-05 18:16:03 PST 
<rdar://problem/29894563>
Comment 2 Sam Weinig 2017-08-16 16:55:01 PDT 
Jiewen, are you working on this? If not, I'll take it.
Comment 3 Jiewen Tan 2017-08-16 17:04:37 PDT 
(In reply to Sam Weinig from comment #2)
> Jiewen, are you working on this? If not, I'll take it.

No, I am not. Feel free to take it.
Comment 4 Sam Weinig 2017-08-17 10:38:02 PDT 
(In reply to Jiewen Tan from comment #3)
> (In reply to Sam Weinig from comment #2)
> > Jiewen, are you working on this? If not, I'll take it.
> 
> No, I am not. Feel free to take it.

Great.
Comment 5 Sam Weinig 2017-08-18 14:24:13 PDT Comment hidden (obsolete)
Comment 6 Build Bot 2017-08-18 14:28:48 PDT Comment hidden (obsolete)
Comment 7 Sam Weinig 2017-08-18 14:58:50 PDT 
Created attachment 318545 [details]
Patch
Comment 8 Jiewen Tan 2017-08-18 16:15:31 PDT 
Comment on attachment 318545 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318545&action=review

Thank you Sam. Looks good. Please address the following comments. Just wondering if you are planning of improving the structure further after the removal of WebKitSubtle?

> Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.h:53
>      bool keyAlgorithmMatches(const CryptoKey&) const;

Maybe we should remove this as well?
Comment 9 Chris Dumez 2017-08-18 16:22:10 PDT 
Comment on attachment 318545 [details]
Patch

rs=me
Comment 10 Sam Weinig 2017-08-18 16:23:53 PDT 
(In reply to Jiewen Tan from comment #8)
> Comment on attachment 318545 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=318545&action=review
> 
> Thank you Sam. Looks good. Please address the following comments. Just
> wondering if you are planning of improving the structure further after the
> removal of WebKitSubtle?

Yeah, this was the first pass. There are a few simplifications I was going to make after this lands.

> 
> > Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.h:53
> >      bool keyAlgorithmMatches(const CryptoKey&) const;
> 
> Maybe we should remove this as well?

If its unused, yes.
Comment 11 Sam Weinig 2017-08-18 16:25:02 PDT 
Committed r220941: <http://trac.webkit.org/changeset/220941>