Bug 164938 – Remove the deprecated WebKitSubtleCrypto interface

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Jiewen Tan]

This is an umbrella bug for deprecating WebKitSubtleCrypto.

[Radar WebKit Bug Importer]

<rdar://problem/29894563>

[Sam Weinig]

Jiewen, are you working on this? If not, I'll take it.

[Jiewen Tan]

(In reply to Sam Weinig from comment #2)
> Jiewen, are you working on this? If not, I'll take it.

No, I am not. Feel free to take it.

[Sam Weinig]

(In reply to Jiewen Tan from comment #3)
> (In reply to Sam Weinig from comment #2)
> > Jiewen, are you working on this? If not, I'll take it.
> 
> No, I am not. Feel free to take it.

Great.

[Sam Weinig]

Created attachment 318540 [details]
Patch

[Build Bot]

Attachment 318540 [details] did not pass style-queue:


ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:795:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:796:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:797:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:798:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:799:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:800:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:801:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:802:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:803:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:804:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/gtk/TestExpectations:805:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/ios-wk1/TestExpectations:1008:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/ios-wk1/TestExpectations:1009:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/ios-wk1/TestExpectations:1010:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/ios-wk1/TestExpectations:1011:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/win/TestExpectations:260:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/win/TestExpectations:261:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/win/TestExpectations:262:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/win/TestExpectations:263:  Path does not exist.  [test/expectations] [5]
Total errors found: 19 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Created attachment 318545 [details]
Patch

[Jiewen Tan]

Comment on attachment 318545 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318545&action=review

Thank you Sam. Looks good. Please address the following comments. Just wondering if you are planning of improving the structure further after the removal of WebKitSubtle?

> Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.h:53
>      bool keyAlgorithmMatches(const CryptoKey&) const;

Maybe we should remove this as well?

[Chris Dumez]

Comment on attachment 318545 [details]
Patch

rs=me

[Sam Weinig]

(In reply to Jiewen Tan from comment #8)
> Comment on attachment 318545 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=318545&action=review
> 
> Thank you Sam. Looks good. Please address the following comments. Just
> wondering if you are planning of improving the structure further after the
> removal of WebKitSubtle?

Yeah, this was the first pass. There are a few simplifications I was going to make after this lands.

> 
> > Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_KW.h:53
> >      bool keyAlgorithmMatches(const CryptoKey&) const;
> 
> Maybe we should remove this as well?

If its unused, yes.

[Sam Weinig]

Committed r220941: <http://trac.webkit.org/changeset/220941>