Bug 169806 - [WebCrypto] Get rid of CryptoKeyData class and all its subclasses
Summary: [WebCrypto] Get rid of CryptoKeyData class and all its subclasses
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks: 164938
  Show dependency tree / graph
 
Reported: 2017-03-16 20:38 PDT by Jiewen Tan
Modified: 2017-08-18 18:42 PDT (History)
6 users (show)

See Also:

Attachments
Patch (84.73 KB, patch)
2017-08-18 16:45 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (86.34 KB, patch)
2017-08-18 17:03 PDT, Sam Weinig 		cdumez: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2017-03-16 20:38:19 PDT 
Since every CryptoKey class now has its own way to export/import bytes, we can get rid of CryptoKeyData which serves a middle layer of serializing CryptoKeys.
Comment 1 Sam Weinig 2017-08-18 16:45:33 PDT 
Created attachment 318558 [details]
Patch
Comment 2 Sam Weinig 2017-08-18 17:03:00 PDT 
Created attachment 318561 [details]
Patch
Comment 3 Chris Dumez 2017-08-18 18:31:37 PDT 
Comment on attachment 318561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318561&action=review

> Source/WebCore/ChangeLog:17
> +          the implementations except the on on CryptoKeyRSA, which now is

typo: the one on
Comment 4 Sam Weinig 2017-08-18 18:40:56 PDT 
Committed r220949: <http://trac.webkit.org/changeset/220949>
Comment 5 Radar WebKit Bug Importer 2017-08-18 18:41:59 PDT 
<rdar://problem/33974719>
Comment 6 Radar WebKit Bug Importer 2017-08-18 18:42:01 PDT 
<rdar://problem/33974720>