Bug 164752 – Make test sandbox-should-not-persist-on-navigation.html more representative of real-world scenario

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Daniel Bates]

Prior to r208549 (bug #164387 the HTTP 0.9 sandbox was applied to a document if either the document loaded on a default port using HTTP 0.9 or one of its subresources loaded on a non-default port. Following r208549 we only apply the sandbox in the former case because the latter case provided little to no additional security. The test LayoutTests/http/tests/security/http-0.9/sandbox-should-not-persist-on-navigation.html makes use the former case. We should write it to test the latter case, which is more representative of a real-world scenario where we would want to apply a sandbox.

[Daniel Bates]

Created attachment 294779 [details]
Layout test

[Build Bot]

Comment on attachment 294779 [details]
Layout test

Attachment 294779 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2516996

New failing tests:
http/tests/security/http-0.9/sandbox-should-not-persist-on-navigation.html

[Build Bot]

Created attachment 294790 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 294779 [details]
Layout test

Attachment 294779 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2517009

New failing tests:
http/tests/security/http-0.9/sandbox-should-not-persist-on-navigation.html

[Build Bot]

Created attachment 294792 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 294779 [details]
Layout test

Attachment 294779 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2517017

New failing tests:
http/tests/security/http-0.9/sandbox-should-not-persist-on-navigation.html

[Build Bot]

Created attachment 294793 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 294779 [details]
Layout test

Attachment 294779 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2517022

New failing tests:
http/tests/security/http-0.9/sandbox-should-not-persist-on-navigation.html

[Build Bot]

Created attachment 294795 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Daniel Bates]

Created attachment 294840 [details]
Layout test

[Brent Fulgham]

Comment on attachment 294840 [details]
Layout test

View in context: https://bugs.webkit.org/attachment.cgi?id=294840&action=review

> LayoutTests/platform/wk2/TestExpectations:559
> +http/tests/security/http-0.9/sandbox-should-not-persist-on-navigation.html

Why do we skip this on WK2?

[Brent Fulgham]

(In reply to comment #11)
> Comment on attachment 294840 [details]
> Layout test
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=294840&action=review
> 
> > LayoutTests/platform/wk2/TestExpectations:559
> > +http/tests/security/http-0.9/sandbox-should-not-persist-on-navigation.html
> 
> Why do we skip this on WK2?

Dan explained to me that the internals flag we use to register a default port for testing purposes is not exposed to WK2, so we don't test under WK2 for this specific feature.

[Brent Fulgham]

Comment on attachment 294840 [details]
Layout test

r=me.

[Daniel Bates]

Comment on attachment 294840 [details]
Layout test

Clearing flags on attachment: 294840

Committed r208796: <http://trac.webkit.org/changeset/208796>

[Daniel Bates]

All reviewed patches have been landed.  Closing bug.