Bug 164387 – REGRESSION (r195004): Scripts and plugins blocked for subsequent loads in same WebContent process after receiving HTTP 0.9 response

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Daniel Bates]

If a page in tab A loads an HTTP 0.9 resource then script execution and plugins will be blocked in all subsequent loads in tab A.

[Radar WebKit Bug Importer]

<rdar://problem/29100985>

[Daniel Bates]

(In reply to comment #0)
> If a page in tab A loads an HTTP 0.9 resource then script execution and
> plugins will be blocked in all subsequent loads in tab A.

I meant to add that we should only block script execution and plugins for a page requested on a default port that loads over HTTP 0.9.

[Daniel Bates]

(In reply to comment #1)
> <rdar://problem/29100985>

Disregard this comment. This bug will be tracked by...

[Daniel Bates]

<rdar://problem/28987537>

[Daniel Bates]

Created attachment 294168 [details]
Patch and layout tests

This patch modifies the test results added in the patch for bug #164389. It also adds a new test to the directory added in the patch for bug #164389. The patch for bug #164389 has not landed as of the time of writing.

[Daniel Bates]

Created attachment 294287 [details]
Patch and layout tests

Rebased patch

[WebKit Commit Bot]

Attachment 294287 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Document.cpp:6913:  Document::shouldEnforceHTTP0_9Sandbox is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/dom/Document.h:1400:  shouldEnforceHTTP0_9Sandbox is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brent Fulgham]

Comment on attachment 294287 [details]
Patch and layout tests

View in context: https://bugs.webkit.org/attachment.cgi?id=294287&action=review

This is a great step in the right direction. Now we behave consistently on loads. Other bugs are being used to deal with the specific ShoutCast issue.

> Source/WebCore/ChangeLog:24
> +        Moreover, we only emit this console message when the document load is not blocked.

Good!

> LayoutTests/http/tests/security/http-0.9/default-port-plugin-blocked-expected.txt:-3
> -CONSOLE MESSAGE: Sandboxing 'http://127.0.0.1:8000/security/http-0.9/resources/nph-load-plugin-fail.pl' because it is using HTTP/0.9.

Great!

[Daniel Bates]

Comment on attachment 294287 [details]
Patch and layout tests

Clearing flags on attachment: 294287

Committed r208549: <http://trac.webkit.org/changeset/208549>

[Daniel Bates]

All reviewed patches have been landed.  Closing bug.