Bug 164387 - REGRESSION (r195004): Scripts and plugins blocked for subsequent loads in same WebContent process after receiving HTTP 0.9 response
Summary: REGRESSION (r195004): Scripts and plugins blocked for subsequent loads in sam...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-11-03 16:31 PDT by Daniel Bates
Modified: 2016-11-10 10:53 PST (History)
12 users (show)

See Also:

Attachments
Patch and layout tests (21.76 KB, patch)
2016-11-08 10:12 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch and layout tests (21.70 KB, patch)
2016-11-09 14:09 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2016-11-03 16:31:14 PDT 
If a page in tab A loads an HTTP 0.9 resource then script execution and plugins will be blocked in all subsequent loads in tab A.
Comment 1 Radar WebKit Bug Importer 2016-11-03 16:31:39 PDT 
<rdar://problem/29100985>
Comment 2 Daniel Bates 2016-11-03 16:34:19 PDT 
(In reply to comment #0)
> If a page in tab A loads an HTTP 0.9 resource then script execution and
> plugins will be blocked in all subsequent loads in tab A.

I meant to add that we should only block script execution and plugins for a page requested on a default port that loads over HTTP 0.9.
Comment 3 Daniel Bates 2016-11-03 19:44:41 PDT 
(In reply to comment #1)
> <rdar://problem/29100985>

Disregard this comment. This bug will be tracked by...
Comment 4 Daniel Bates 2016-11-03 19:44:49 PDT 
<rdar://problem/28987537>
Comment 5 Daniel Bates 2016-11-08 10:12:22 PST 
Created attachment 294168 [details]
Patch and layout tests

This patch modifies the test results added in the patch for bug #164389. It also adds a new test to the directory added in the patch for bug #164389. The patch for bug #164389 has not landed as of the time of writing.
Comment 6 Daniel Bates 2016-11-09 14:09:38 PST 
Created attachment 294287 [details]
Patch and layout tests

Rebased patch
Comment 7 WebKit Commit Bot 2016-11-09 14:12:21 PST 
Attachment 294287 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/Document.cpp:6913:  Document::shouldEnforceHTTP0_9Sandbox is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/dom/Document.h:1400:  shouldEnforceHTTP0_9Sandbox is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Brent Fulgham 2016-11-09 14:43:18 PST 
Comment on attachment 294287 [details]
Patch and layout tests

View in context: https://bugs.webkit.org/attachment.cgi?id=294287&action=review

This is a great step in the right direction. Now we behave consistently on loads. Other bugs are being used to deal with the specific ShoutCast issue.

> Source/WebCore/ChangeLog:24
> +        Moreover, we only emit this console message when the document load is not blocked.

Good!

> LayoutTests/http/tests/security/http-0.9/default-port-plugin-blocked-expected.txt:-3
> -CONSOLE MESSAGE: Sandboxing 'http://127.0.0.1:8000/security/http-0.9/resources/nph-load-plugin-fail.pl' because it is using HTTP/0.9.

Great!
Comment 9 Daniel Bates 2016-11-10 10:53:14 PST 
Comment on attachment 294287 [details]
Patch and layout tests

Clearing flags on attachment: 294287

Committed r208549: <http://trac.webkit.org/changeset/208549>
Comment 10 Daniel Bates 2016-11-10 10:53:20 PST 
All reviewed patches have been landed.  Closing bug.