Bug 164713 – Fix the !ENABLE(FETCH_API) build after r208613

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Csaba Osztrogonác]

DerivedSources/WebCore/JSWorkerGlobalScope.cpp: In member function 'void WebCore::JSWorkerGlobalScopePrototype::finishCreation(JSC::VM&)':
DerivedSources/WebCore/JSWorkerGlobalScope.cpp:544:124: error: 'jsWorkerGlobalScopePrototypeFunctionFetchRequest' was not declared in this scope

[Csaba Osztrogonác]

...
#if ENABLE(FETCH_API)
JSC::EncodedJSValue JSC_HOST_CALL jsWorkerGlobalScopePrototypeFunctionFetchRequest(JSC::ExecState*);
#endif
...
void JSWorkerGlobalScopePrototype::finishCreation(VM& vm)
{
    Base::finishCreation(vm);
    reifyStaticProperties(vm, JSWorkerGlobalScopePrototypeTableValues, *this);
#if ENABLE(FETCH_API)
    if (!RuntimeEnabledFeatures::sharedFeatures().fetchAPIEnabled()) {
        Identifier propertyName = Identifier::fromString(&vm, reinterpret_cast<const LChar*>("fetch"), strlen("fetch"));
        VM::DeletePropertyModeScope scope(vm, VM::DeletePropertyMode::IgnoreConfigurable);
        JSObject::deleteProperty(this, globalObject()->globalExec(), propertyName);
    }
#endif
#if ENABLE(INDEXED_DATABASE_IN_WORKERS)
    if (!RuntimeEnabledFeatures::sharedFeatures().indexedDBWorkersEnabled()) {
        Identifier propertyName = Identifier::fromString(&vm, reinterpret_cast<const LChar*>("indexedDB"), strlen("indexedDB"));
        VM::DeletePropertyModeScope scope(vm, VM::DeletePropertyMode::IgnoreConfigurable);
        JSObject::deleteProperty(this, globalObject()->globalExec(), propertyName);
    }
#endif
    JSVMClientData& clientData = *static_cast<JSVMClientData*>(vm.clientData);
    putDirect(vm, clientData.builtinNames().fetchRequestPrivateName(), JSFunction::create(vm, globalObject(), 0, String(), jsWorkerGlobalScopePrototypeFunctionFetchRequest), ReadOnly | DontEnum); <-------------------- BANG!!! This line should be guarded.
}

[Csaba Osztrogonác]

I bisected, it is a regression caused by http://trac.webkit.org/changeset/208613 .

[Chris Dumez]

I am investigating, thanks.

[Chris Dumez]

Created attachment 294705 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 294705 [details]
Patch

Clearing flags on attachment: 294705

Committed r208689: <http://trac.webkit.org/changeset/208689>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.