Bug 164644 - WorkerGlobalScope's indexedDB property should be on the prototype, not the instance
Summary: WorkerGlobalScope's indexedDB property should be on the prototype, not the in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 164713
Blocks:
  Show dependency tree / graph
 
Reported: 2016-11-11 11:05 PST by Chris Dumez
Modified: 2016-11-14 08:53 PST (History)
6 users (show)

See Also:

Attachments
Patch (74.87 KB, patch)
2016-11-11 14:07 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (76.18 KB, patch)
2016-11-11 14:12 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-11-11 11:05:43 PST 
WorkerGlobalScope's indexedDB property should be on the prototype, not the instance.

Causing failure on http://w3c-test.org/IndexedDB/interfaces.worker.html
Comment 1 Chris Dumez 2016-11-11 11:10:58 PST 
This is because WorkerGlobalScope is not a [Global] object, DedicatedWorkerGlobalScope is. Therefore, WorkerGlobalScope should have its properties / operations on the prototype, except for the constructors (such as IDBDatabase).
Comment 2 Chris Dumez 2016-11-11 14:07:57 PST 
Created attachment 294534 [details]
Patch
Comment 3 Chris Dumez 2016-11-11 14:12:04 PST 
Created attachment 294535 [details]
Patch
Comment 4 Brady Eidson 2016-11-11 14:13:53 PST 
Comment on attachment 294535 [details]
Patch

LGTM once all the little bot bubbles are green!
Comment 5 Chris Dumez 2016-11-11 14:56:33 PST 
Comment on attachment 294535 [details]
Patch

Clearing flags on attachment: 294535

Committed r208613: <http://trac.webkit.org/changeset/208613>
Comment 6 Chris Dumez 2016-11-11 14:56:38 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Csaba Osztrogonác 2016-11-14 08:53:57 PST 
(In reply to comment #5)
> Comment on attachment 294535 [details]
> Patch
> 
> Clearing flags on attachment: 294535
> 
> Committed r208613: <http://trac.webkit.org/changeset/208613>

It broke the !ENABLE(FETCH_API) build, I filed a bug report
about this regression, see bug164713 for details.