WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
164638
Get rid of old sandbox rules for OS's we no longer support
https://bugs.webkit.org/show_bug.cgi?id=164638
Summary
Get rid of old sandbox rules for OS's we no longer support
Brent Fulgham
Reported
2016-11-11 09:52:13 PST
The existing Sandbox profiles refer to various unsupported versions of macOS. These conditionals are evaluated at runtime, so have a non-zero cost, and are always false for anything shipped in the last few years. Clean up these old entries!
Attachments
Patch
(7.76 KB, patch)
2016-11-11 10:51 PST
,
Brent Fulgham
simon.fraser
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2016-11-11 10:51:57 PST
Created
attachment 294507
[details]
Patch
Brent Fulgham
Comment 2
2016-11-11 14:19:46 PST
Committed
r208611
: <
http://trac.webkit.org/changeset/208611
>
Brent Fulgham
Comment 3
2016-11-29 19:51:30 PST
This change is wrong. I misread the Scheme conditional clause as if it was C++, instead I should have recognized that Scheme's conditional looks like this: (if (predicate ...) (stuff to do if true) (stuff to do if false)) I will fix this in
Bug 165187
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug