Bug 164638 - Get rid of old sandbox rules for OS's we no longer support
Summary: Get rid of old sandbox rules for OS's we no longer support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-11 09:52 PST by Brent Fulgham
Modified: 2016-11-29 19:51 PST (History)
5 users (show)

See Also:

Attachments
Patch (7.76 KB, patch)
2016-11-11 10:51 PST, Brent Fulgham 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2016-11-11 09:52:13 PST 
The existing Sandbox profiles refer to various unsupported versions of macOS. These conditionals are evaluated at runtime, so have a non-zero cost, and are always false for anything shipped in the last few years.

Clean up these old entries!
Comment 1 Brent Fulgham 2016-11-11 10:51:57 PST 
Created attachment 294507 [details]
Patch
Comment 2 Brent Fulgham 2016-11-11 14:19:46 PST 
Committed r208611: <http://trac.webkit.org/changeset/208611>
Comment 3 Brent Fulgham 2016-11-29 19:51:30 PST 
This change is wrong. I misread the Scheme conditional clause as if it was C++, instead I should have recognized that Scheme's conditional looks like this:

(if (predicate ...)
    (stuff to do if true)
    (stuff to do if false))

I will fix this in Bug 165187.