Bug 165187 - Correct plugin sandbox after r208611
Summary: Correct plugin sandbox after r208611
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-11-29 19:51 PST by Brent Fulgham
Modified: 2016-11-30 09:53 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.08 KB, patch)
2016-11-29 20:01 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2016-11-29 19:51:11 PST 
I misread the Scheme conditional clause I changed in <http://trac.webkit.org/changeset/208611> as if it was C++.

I should have recognized that Scheme's conditional looks like this:

(if (predicate ...)
    (stuff to do if true)
    (stuff to do if false))

Therefore, much of what I stripped out is still needed.
Comment 1 Brent Fulgham 2016-11-29 19:58:22 PST 
<rdar://problem/29431165>
Comment 2 Brent Fulgham 2016-11-29 20:01:12 PST 
Created attachment 295696 [details]
Patch
Comment 3 WebKit Commit Bot 2016-11-30 09:53:32 PST 
Comment on attachment 295696 [details]
Patch

Clearing flags on attachment: 295696

Committed r209133: <http://trac.webkit.org/changeset/209133>
Comment 4 WebKit Commit Bot 2016-11-30 09:53:36 PST 
All reviewed patches have been landed.  Closing bug.