Bug 164592 - REGRESSION (r208509): LayoutTest storage/domstorage/sessionstorage/blocked-file-access.html is failing
Summary: REGRESSION (r208509): LayoutTest storage/domstorage/sessionstorage/blocked-fi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 155609
Blocks:
  Show dependency tree / graph
 
Reported: 2016-11-10 08:38 PST by Ryan Haddad
Modified: 2016-11-10 11:03 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-11-10 08:38:06 PST 
LayoutTest storage/domstorage/sessionstorage/blocked-file-access.html is failing

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r208537%20(1310)/results.html

--- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/storage/domstorage/sessionstorage/blocked-file-access-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/storage/domstorage/sessionstorage/blocked-file-access-actual.txt
@@ -1,3 +1,4 @@
-CONSOLE MESSAGE: line 10: PASS: window.sessionStorage was accessible
+CONSOLE MESSAGE: line 12: FAIL: window.sessionStorage was not accessible
+CONSOLE MESSAGE: line 13: Exception: The operation is insecure.
 
 Test that we are permitted access to sessionStorage from a file URL if universal access is turned off.
Comment 1 Ryan Haddad 2016-11-10 09:26:02 PST 
Started with http://trac.webkit.org/changeset/208509
Comment 2 Brent Fulgham 2016-11-10 09:57:03 PST 
(In reply to comment #1)
> Started with http://trac.webkit.org/changeset/208509

Not surprising -- since that is the checkin that added that test! :-)
Comment 3 Brent Fulgham 2016-11-10 09:59:04 PST 
(In reply to comment #2)
> (In reply to comment #1)
> > Started with http://trac.webkit.org/changeset/208509
> 
> Not surprising -- since that is the checkin that added that test! :-)

Oh, wait! This is domstorage, not local storage. I'll fix.
Comment 4 Brent Fulgham 2016-11-10 10:06:36 PST 
This problem was introduced because the fix for this (https://trac.webkit.org/changeset/198439) was lost during the rollout of the localStorage change, too.

I'll fix this shortly.
Comment 5 Brent Fulgham 2016-11-10 10:07:58 PST 
This is effectively a duplicate of Bug 155609.
Comment 6 Brent Fulgham 2016-11-10 11:03:03 PST 
Fixed by r208550 <https://trac.webkit.org/changeset/208550>.